RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1436119 - the error information is not accurate when creating a vol with "--capacity -1"
Summary: the error information is not accurate when creating a vol with "--capacity -1"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.4
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Ján Tomko
QA Contact: jiyan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-27 08:34 UTC by lijuan men
Modified: 2017-08-02 00:03 UTC (History)
5 users (show)

Fixed In Version: libvirt-3.2.0-1.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 17:24:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1846 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2017-08-01 18:02:50 UTC

Description lijuan men 2017-03-27 08:34:38 UTC
Description of problem:
the error information is not accurate when creating a vol with "--capacity -1"

Version-Release number of selected component (if applicable):
libvirt-3.1.0-2.el7.x86_64
qemu-kvm-rhev-2.8.0-6.el7.x86_64

How reproducible:
100%

Steps to Reproduce:

[root@localhost ~]# virsh vol-create-as  default test  --capacity -1
error: Failed to create vol test
error: numerical overflow: value too large: 18446744073709551615


Actual results:
the error information is not accurate,the value I set is -1,not 18446744073709551615

Expected results:

the error information should be like this:

[root@localhost ~]# virsh vol-create-as  default test 1.0
error: Malformed size 1.0



Additional info:

Comment 2 Ján Tomko 2017-03-27 15:24:47 UTC
Pushed upstream:
commit 2da7f545a34747ae21d73ce1369a6d2055f94ea4
Author:     Ján Tomko <jtomko>
CommitDate: 2017-03-27 17:20:03 +0200

    storage: reject negative capacity
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1436119

commit df6551feb47b83c70d099b9c0d7cdf3ca2410760
Author:     Ján Tomko <jtomko>
CommitDate: 2017-03-27 17:20:03 +0200

    virsh: reject more negative numbers
    
    Be more positive and reject negative numbers where we don't
    allow them by using the virStrToLong variants with 'p'.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1436119

git describe: v3.1.0-374-gdf6551f

Comment 4 jiyan 2017-04-11 02:03:39 UTC
version:
libvirt-3.2.0-1.el7.x86_64
qemu-kvm-rhev-2.8.0-6.el7.x86_64
kernel-3.10.0-568.el7.x86_64

step:
[root@localhost ~]# virsh vol-create-as default test  --capacity -1
error: Malformed size -1

The actual result matches the expected now!

Comment 5 errata-xmlrpc 2017-08-01 17:24:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846

Comment 6 errata-xmlrpc 2017-08-02 00:03:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846


Note You need to log in before you can comment on or make changes to this bug.