Bug 1436249

Summary:	Print audio codec used for record/playback channels during channel creation in debug outputs
Product:	Red Hat Enterprise Linux 7	Reporter:	David Jaša <djasa>
Component:	spice-gtk	Assignee:	Default Assignee for SPICE Bugs <rh-spice-bugs>
Status:	CLOSED ERRATA	QA Contact:	SPICE QE bug list <spice-qe-bugs>
Severity:	unspecified	Docs Contact:	Victor Toso <victortoso>
Priority:	unspecified
Version:	7.4	CC:	djasa, pgrunt, rbalakri, tpelka, victortoso
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spice-gtk-0.33-4.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1436251 (view as bug list)		Environment:
Last Closed:	2017-08-01 15:06:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Jaša 2017-03-27 13:54:37 UTC

Description of problem:
It's useful to know what codec is used for playback/record channels so spice-gtk could print to debug output at channel creation.

Version-Release number of selected component (if applicable):
spice-gtk3-0.33-1.el7.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Victor Toso 2017-03-27 14:07:49 UTC

At channel creation we don't know. We know based on SPICE_MSG_PLAYBACK_MODE message which we print a message (in playback):

https://cgit.freedesktop.org/spice/spice-gtk/tree/src/channel-playback.c#n349

I guess it would be more clear to include the mode/codec as string when we recebe the start message (SPICE_MSG_PLAYBACK_START and SPICE_MSG_RECORD_START).

Looks good to you?

Comment 2 David Jaša 2017-03-28 09:06:23 UTC

(In reply to Victor Toso from comment #1)
> At channel creation we don't know. We know based on SPICE_MSG_PLAYBACK_MODE
> message which we print a message (in playback):
> 
> https://cgit.freedesktop.org/spice/spice-gtk/tree/src/channel-playback.c#n349
> 
> I guess it would be more clear to include the mode/codec as string when we
> recebe the start message (SPICE_MSG_PLAYBACK_START and
> SPICE_MSG_RECORD_START).
> 
> Looks good to you?

Yeah, that would be great. Thanks!

Comment 3 Victor Toso 2017-03-28 11:50:59 UTC

Patch sent
https://lists.freedesktop.org/archives/spice-devel/2017-March/036808.html

Comment 4 Victor Toso 2017-04-07 10:03:02 UTC

Patch pushed 7721d0906d55cfaa6ce8f5786829c5c738adf74c

Comment 7 errata-xmlrpc 2017-08-01 15:06:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1849