Bug 1436766

Summary: Crunched display of disk targets in move and copy when VM/SD name is long and contains hyphens
Product: [oVirt] ovirt-engine Reporter: Kevin Alon Goldblatt <kgoldbla>
Component: Frontend.WebAdminAssignee: Benny Zlotnik <bzlotnik>
Status: CLOSED CURRENTRELEASE QA Contact: Lucie Leistnerova <lleistne>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.1.1.5CC: amureini, bugs, bzlotnik, lsvaty, stirabos, tnisan
Target Milestone: ovirt-4.1.4Flags: rule-engine: ovirt-4.1+
lsvaty: testing_ack+
Target Release: 4.1.4.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: webadmin
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-28 14:18:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screen shot
none
copy-disk-screenshot
none
4.1.3 screenshot
none
4.1.3_long_storage_name none

Description Kevin Alon Goldblatt 2017-03-28 15:21:08 UTC 
Description of problem:
The display of disks in the cold move operation is crunched

Version-Release number of selected component (if applicable):
ovirt-engine-4.1.1.6-0.1.el7.noarch
rhevm-4.1.1.6-0.1.el7.noarch
vdsm-4.19.10-1.el7ev.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create Storage Domains with long names like local_on_host1 and local_on_host2
2. Create vm with 3 disks with the name vm_on_local
2. Select all 3 disks via the WebAdmin->VM->Disks and press the 'move' option

The target domains are crunched in the display window and are pushed down a line
The window cannot be resized either. See Screen shot
 


Actual results:


Expected results:


Additional info:
Comment 1 Kevin Alon Goldblatt 2017-03-28 15:22:14 UTC 
Created attachment 1267012 [details]
screen shot

added screen shot
Comment 2 Benny Zlotnik 2017-05-23 14:12:05 UTC 
Note: this also affects copy disk
Comment 3 Benny Zlotnik 2017-05-23 14:12:36 UTC 
Created attachment 1281572 [details]
copy-disk-screenshot
Comment 4 Benny Zlotnik 2017-06-15 15:48:04 UTC 
Created attachment 1288110 [details]
4.1.3 screenshot
Comment 5 Benny Zlotnik 2017-06-15 15:51:31 UTC 
Does not currently reproduce on 4.1.2+
Comment 6 Lucie Leistnerova 2017-06-20 11:43:54 UTC 
I was able to reproduce it on 4.1.2.1 also in 4.1.3.

The problem is not in long disk name, but in long storage name in Source column. 
See screenshot.

tested in ovirt-engine-webadmin-portal-4.1.3.4-0.1.el7.noarch
Comment 7 Red Hat Bugzilla Rules Engine 2017-06-20 11:43:59 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 8 Lucie Leistnerova 2017-06-20 11:44:37 UTC 
Created attachment 1289609 [details]
4.1.3_long_storage_name
Comment 9 Benny Zlotnik 2017-06-20 12:56:39 UTC 
OK, so what I missed was that it isn't enough for the name to be long, it has to contain a hyphen which causes a line-break to be inserted because the component isn't set to be nowrap.

Thanks Lucie!
Comment 12 Allon Mureinik 2017-06-26 08:02:44 UTC 
Based on comment 6 and comment 7, it seems the description isn't accurate. Benny, can you please change edit the title and add exact steps to reproduce?

Also - I see that https://gerrit.ovirt.org/#/c/77750/ is merged to the 4.1 branch.
Are we waiting for anything else, or should this BZ be MODIFIED?
Comment 13 Benny Zlotnik 2017-06-26 09:07:35 UTC 
Updated steps to reproduce:
1. Create a VM with multiple disks with a long name with hyphens (Like in Lucie's screenshot).
2. Select multiple disks and attempt to move/copy them.
Comment 14 Lucie Leistnerova 2017-07-18 08:21:05 UTC 
The names are not wrapped and so the table looks good.

verified in ovirt-engine-webadmin-portal-4.1.4.1-0.1.el7.noarch

Other thing is that there is not visible the whole name and they couldn't be recognized when the name differs only in the end. So I suggest to add hover text there and I created Bug 1472161 for it.