Bug 1436766 - Crunched display of disk targets in move and copy when VM/SD name is long and contains hyphens
Summary: Crunched display of disk targets in move and copy when VM/SD name is long and...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.1.5
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.4
: 4.1.4.1
Assignee: Benny Zlotnik
QA Contact: Lucie Leistnerova
URL:
Whiteboard: webadmin
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-03-28 15:21 UTC by Kevin Alon Goldblatt
Modified: 2017-07-28 14:18 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-07-28 14:18:44 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
lsvaty: testing_ack+


Attachments (Terms of Use)
screen shot (236.31 KB, image/png)
2017-03-28 15:22 UTC, Kevin Alon Goldblatt
no flags Details
copy-disk-screenshot (31.04 KB, image/png)
2017-05-23 14:12 UTC, Benny Zlotnik
no flags Details
4.1.3 screenshot (37.33 KB, image/png)
2017-06-15 15:48 UTC, Benny Zlotnik
no flags Details
4.1.3_long_storage_name (32.47 KB, image/png)
2017-06-20 11:44 UTC, Lucie Leistnerova
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 77182 0 master MERGED webadmin: make each disk appear on its own separate line 2017-05-31 20:31:08 UTC
oVirt gerrit 77750 0 ovirt-engine-4.1 MERGED webadmin: make each disk appear on its own separate line 2017-06-25 08:39:31 UTC
oVirt gerrit 78341 0 master ABANDONED webadmin: add nowrap rule to EnableableFormLabel 2017-06-21 13:23:40 UTC
oVirt gerrit 78342 0 ovirt-engine-4.1 ABANDONED webadmin: add nowrap rule to EnableableFormLabel 2017-06-21 13:13:21 UTC

Description Kevin Alon Goldblatt 2017-03-28 15:21:08 UTC
Description of problem:
The display of disks in the cold move operation is crunched

Version-Release number of selected component (if applicable):
ovirt-engine-4.1.1.6-0.1.el7.noarch
rhevm-4.1.1.6-0.1.el7.noarch
vdsm-4.19.10-1.el7ev.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create Storage Domains with long names like local_on_host1 and local_on_host2
2. Create vm with 3 disks with the name vm_on_local
2. Select all 3 disks via the WebAdmin->VM->Disks and press the 'move' option

The target domains are crunched in the display window and are pushed down a line
The window cannot be resized either. See Screen shot
 


Actual results:


Expected results:


Additional info:

Comment 1 Kevin Alon Goldblatt 2017-03-28 15:22:14 UTC
Created attachment 1267012 [details]
screen shot

added screen shot

Comment 2 Benny Zlotnik 2017-05-23 14:12:05 UTC
Note: this also affects copy disk

Comment 3 Benny Zlotnik 2017-05-23 14:12:36 UTC
Created attachment 1281572 [details]
copy-disk-screenshot

Comment 4 Benny Zlotnik 2017-06-15 15:48:04 UTC
Created attachment 1288110 [details]
4.1.3 screenshot

Comment 5 Benny Zlotnik 2017-06-15 15:51:31 UTC
Does not currently reproduce on 4.1.2+

Comment 6 Lucie Leistnerova 2017-06-20 11:43:54 UTC
I was able to reproduce it on 4.1.2.1 also in 4.1.3.

The problem is not in long disk name, but in long storage name in Source column. 
See screenshot.

tested in ovirt-engine-webadmin-portal-4.1.3.4-0.1.el7.noarch

Comment 7 Red Hat Bugzilla Rules Engine 2017-06-20 11:43:59 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 8 Lucie Leistnerova 2017-06-20 11:44:37 UTC
Created attachment 1289609 [details]
4.1.3_long_storage_name

Comment 9 Benny Zlotnik 2017-06-20 12:56:39 UTC
OK, so what I missed was that it isn't enough for the name to be long, it has to contain a hyphen which causes a line-break to be inserted because the component isn't set to be nowrap.

Thanks Lucie!

Comment 12 Allon Mureinik 2017-06-26 08:02:44 UTC
Based on comment 6 and comment 7, it seems the description isn't accurate. Benny, can you please change edit the title and add exact steps to reproduce?

Also - I see that https://gerrit.ovirt.org/#/c/77750/ is merged to the 4.1 branch.
Are we waiting for anything else, or should this BZ be MODIFIED?

Comment 13 Benny Zlotnik 2017-06-26 09:07:35 UTC
Updated steps to reproduce:
1. Create a VM with multiple disks with a long name with hyphens (Like in Lucie's screenshot).
2. Select multiple disks and attempt to move/copy them.

Comment 14 Lucie Leistnerova 2017-07-18 08:21:05 UTC
The names are not wrapped and so the table looks good.

verified in ovirt-engine-webadmin-portal-4.1.4.1-0.1.el7.noarch

Other thing is that there is not visible the whole name and they couldn't be recognized when the name differs only in the end. So I suggest to add hover text there and I created Bug 1472161 for it.


Note You need to log in before you can comment on or make changes to this bug.