Bug 1438090

Summary:	Review Request: GetIt - Application to send HTTP requests
Product:	[Fedora] Fedora	Reporter:	Bart Kessels <bartkessels>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedora, jkalina, package-review, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-01 13:50:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841

Description Bart Kessels 2017-03-31 21:41:28 UTC

Spec URL: https://raw.githubusercontent.com/bartkessels/getit/master/getit.spec
SRPM URL: https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc25.src.rpm?raw=true
SRPM URL: https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc26.src.rpm?raw=true
Description: Application to send HTTP requests to API's. Has the ability to send form-data, files, headers and authentication (basic auth and digest auth)
Fedora Account System Username: bartkessels

This the first package I've ever created, so if anyone wants to help improve please feel free to do so! Since I'm also the developer of the application the bugs reported will be fixed as fast as possible.

The source of the application:
https://github.com/bartkessels/getit

The application has been tested on the koji build system (for both Fedora 25 and Fedora 26) and the results can be found here:
Fedora 25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703853
Fedora 26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703954

Comment 1 Artur Frenszek-Iwicki 2017-04-02 19:40:49 UTC

I am not a packager, so this is not an official review.

Your %files section does not include the %license.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Comment 2 Bart Kessels 2017-04-02 20:16:21 UTC

(In reply to iwicki.artur from comment #1)
> I am not a packager, so this is not an official review.
> 
> Your %files section does not include the %license.
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Thank you, just added the %license to the %files section.

Comment 3 Jan Kalina 2017-06-01 09:42:34 UTC

(not official review)

Source0 is invalid - it resolves to "getit-1.2.tar.gz", but Github sends "GetIt-1.1-1.fc26.src.rpm", so fedora-review and similar tools fails to build, as they are not able to find downloaded file.

You should also attach ONLY ONE SRPM in one review request - as any review should be against rawhide, it does not make sense to attach SRPMs for more fedora releases.

Comment 4 Zbigniew Jędrzejewski-Szmek 2017-07-15 04:29:58 UTC

Hm, what happened here?