Spec URL: https://raw.githubusercontent.com/bartkessels/getit/master/getit.spec SRPM URL: https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc25.src.rpm?raw=true SRPM URL: https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc26.src.rpm?raw=true Description: Application to send HTTP requests to API's. Has the ability to send form-data, files, headers and authentication (basic auth and digest auth) Fedora Account System Username: bartkessels This the first package I've ever created, so if anyone wants to help improve please feel free to do so! Since I'm also the developer of the application the bugs reported will be fixed as fast as possible. The source of the application: https://github.com/bartkessels/getit The application has been tested on the koji build system (for both Fedora 25 and Fedora 26) and the results can be found here: Fedora 25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703853 Fedora 26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703954
I am not a packager, so this is not an official review. Your %files section does not include the %license. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
(In reply to iwicki.artur from comment #1) > I am not a packager, so this is not an official review. > > Your %files section does not include the %license. > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Thank you, just added the %license to the %files section.
(not official review) Source0 is invalid - it resolves to "getit-1.2.tar.gz", but Github sends "GetIt-1.1-1.fc26.src.rpm", so fedora-review and similar tools fails to build, as they are not able to find downloaded file. You should also attach ONLY ONE SRPM in one review request - as any review should be against rawhide, it does not make sense to attach SRPMs for more fedora releases.
Hm, what happened here?