Bug 1438269

Summary: ceph plugin does not collect /etc/calamari or /var/lib/ceph
Product: Red Hat Enterprise Linux 7 Reporter: Pavel Moravec <pmoravec>
Component: sosAssignee: Pavel Moravec <pmoravec>
Status: CLOSED ERRATA QA Contact: Miroslav HradĂ­lek <mhradile>
Severity: medium Docs Contact:
Priority: high    
Version: 7.4CC: agk, bmr, gavin, mhradile, plambri, sbradley
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/sosreport/sos/pull/987
Whiteboard:
Fixed In Version: sos-3.4-3.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 23:10:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pavel Moravec 2017-04-02 15:29:56 UTC
Description of problem:
Due to a typo (missing coma) in ceph plugin:

        self.add_copy_spec([
            "/etc/ceph/",
            "/etc/calamari/"
            "/var/lib/ceph/",
            "/var/run/ceph/"
        ])

, sosreport does not collect either of directories /etc/calamari or /var/lib/ceph.

Version-Release number of selected component (if applicable):
sos-3.4-1.el7.noarch


How reproducible:
100%


Steps to Reproduce:
1.
mkdir /etc/calamari/ /var/lib/ceph
date > /etc/calamari/whatever.conf
date > /var/lib/ceph/whatever.varlib

2. sosreport -vv -o ceph --batch
3. Check if both files are collected.


Actual results:
Neither file is collected now.


Expected results:
Both files should be collected.


Additional info:

Comment 2 Pavel Moravec 2017-04-20 15:21:13 UTC
*** Bug 1444088 has been marked as a duplicate of this bug. ***

Comment 3 Bryn M. Reeves 2017-04-20 15:25:29 UTC
commit 44f3e7332516f09738dc865e943eb70eceb50553
Author: Bryn M. Reeves <bmr>
Date:   Thu Apr 20 16:19:46 2017 +0100

    [ceph] fix list formatting
    
    Fix the formatting of the add_copy_spec() lists in ceph: make the
    first conform to the sos bracing and indenting rules for lists in
    argument tuples, and fix a missing comma in the second.
    
    Signed-off-by: Bryn M. Reeves <bmr>

Comment 8 errata-xmlrpc 2017-08-01 23:10:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2203