Bug 1438269 – ceph plugin does not collect /etc/calamari or /var/lib/ceph

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1438269 - ceph plugin does not collect /etc/calamari or /var/lib/ceph

Summary:	ceph plugin does not collect /etc/calamari or /var/lib/ceph

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	sos (Show other bugs)
Sub Component:
Version:	7.4
Hardware:	All Linux

Priority	high Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	Pavel Moravec
QA Contact:	Miroslav Hradílek
Docs Contact:

URL:	https://github.com/sosreport/sos/pull...
Whiteboard:
Keywords:	Regression

Duplicates:	1444088 (view as bug list)
Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-04-02 11:29 EDT by Pavel Moravec
Modified:	2017-08-01 19:10 EDT (History)
CC List:	6 users (show)

See Also:
Fixed In Version:	sos-3.4-3.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-08-01 19:10:42 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2017:2203	normal	SHIPPED_LIVE	sos bug fix and enhancement update	2017-08-01 15:41:56 EDT

Groups: None (edit)

Description Pavel Moravec 2017-04-02 11:29:56 EDT

Description of problem:
Due to a typo (missing coma) in ceph plugin:

        self.add_copy_spec([
            "/etc/ceph/",
            "/etc/calamari/"
            "/var/lib/ceph/",
            "/var/run/ceph/"
        ])

, sosreport does not collect either of directories /etc/calamari or /var/lib/ceph.

Version-Release number of selected component (if applicable):
sos-3.4-1.el7.noarch


How reproducible:
100%


Steps to Reproduce:
1.
mkdir /etc/calamari/ /var/lib/ceph
date > /etc/calamari/whatever.conf
date > /var/lib/ceph/whatever.varlib

2. sosreport -vv -o ceph --batch
3. Check if both files are collected.


Actual results:
Neither file is collected now.


Expected results:
Both files should be collected.


Additional info:

Comment 2 Pavel Moravec 2017-04-20 11:21:13 EDT

*** Bug 1444088 has been marked as a duplicate of this bug. ***

Comment 3 Bryn M. Reeves 2017-04-20 11:25:29 EDT

commit 44f3e7332516f09738dc865e943eb70eceb50553
Author: Bryn M. Reeves <bmr@redhat.com>
Date:   Thu Apr 20 16:19:46 2017 +0100

    [ceph] fix list formatting
    
    Fix the formatting of the add_copy_spec() lists in ceph: make the
    first conform to the sos bracing and indenting rules for lists in
    argument tuples, and fix a missing comma in the second.
    
    Signed-off-by: Bryn M. Reeves <bmr@redhat.com>

Comment 8 errata-xmlrpc 2017-08-01 19:10:42 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2203

Note You need to log in before you can comment on or make changes to this bug.