Bug 1438822

Summary:	The discard_enable flag should not be used anymore in oVirt 4.2
Product:	[oVirt] vdsm	Reporter:	Idan Shaby <ishaby>
Component:	General	Assignee:	Idan Shaby <ishaby>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Elad <ebenahar>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.20.0	CC:	amureini, bugs, melewis, tnisan
Target Milestone:	ovirt-4.2.0	Flags:	rule-engine: ovirt-4.2+
Target Release:	4.20.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Release Note
Doc Text:	With this update, support for configuring "Discard After Delete" per host has been dropped. This also drops the value "discard_enable" from the VDSM configuration file. The "Discard After Delete" feature now needs to be configured per block storage domain. For more information see - http://www.ovirt.org/develop/release-management/features/storage/discard-after-delete/	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 11:11:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Idan Shaby 2017-04-04 13:36:10 UTC

Description of problem:
The discard_enable flag should not be used anymore in oVirt 4.2 as the engine manages logical volumes discarding from oVirt 4.1.

For more information, please refer to the Discard After Delete feature page:
http://www.ovirt.org/develop/release-management/features/storage/discard-after-delete/

Comment 1 Elad 2017-10-01 15:11:07 UTC

Discard is sent as false in case vdsm.conf has 'discard_enable = true' and the block based domain that its disk is deleted has discard=false.

2017-10-01 18:08:01,085+0300 INFO  (jsonrpc/5) [vdsm.api] START deleteImage(sdUUID='ff9c51b2-eb5c-46c1-88ba-e4c07fb912fb', spUUID='2669a110-2c7b-45d9-86f2-4ce975a04ba2', imgUUID='b9795727-a
fcc-44cf-a189-c493fdf60305', postZero='false', force='false', discard=False) from=::ffff:10.35.161.182,58156, flow_id=493f8172-f8f1-4ec7-b3c6-45ea259e2683, task_id=11fe8358-8fba-45c9-9958-0
a321b2571f1 (api:46)


vdsm.conf:

[vars]
ssl = true

[addresses]
management_port = 54321

[irs]
discard_enable = true


vdsmd was restarted after vdsm.conf modification and before disk deletion from the block based domain.

Verified using:
vdsm-4.20.3-121.git77235c7.el7.centos.x86_64
ovirt-engine-4.2.0-0.0.master.20170929123516.git007c392.el7.centos.noarch

Comment 2 Sandro Bonazzola 2017-12-20 11:11:23 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.