Bug 1438822 - The discard_enable flag should not be used anymore in oVirt 4.2
Summary: The discard_enable flag should not be used anymore in oVirt 4.2
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: 4.20.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.2.0
: 4.20.4
Assignee: Idan Shaby
QA Contact: Elad
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-04 13:36 UTC by Idan Shaby
Modified: 2017-12-20 11:11 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:11:23 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 981626 0 high CLOSED [RFE] Send discard when deleting virtual disks from block based storage domain to regain space in thin provisioned stora... 2021-08-30 11:49:57 UTC
Red Hat Bugzilla 1342919 0 high CLOSED [RFE] Make discard configurable by a storage domain rather than a host 2021-02-22 00:41:40 UTC
oVirt gerrit 75146 0 master MERGED storage: remove discard_enable flag from config file 2020-10-28 20:53:36 UTC

Internal Links: 981626 1342919

Description Idan Shaby 2017-04-04 13:36:10 UTC 
Description of problem:
The discard_enable flag should not be used anymore in oVirt 4.2 as the engine manages logical volumes discarding from oVirt 4.1.

For more information, please refer to the Discard After Delete feature page:
http://www.ovirt.org/develop/release-management/features/storage/discard-after-delete/
Comment 1 Elad 2017-10-01 15:11:07 UTC 
Discard is sent as false in case vdsm.conf has 'discard_enable = true' and the block based domain that its disk is deleted has discard=false.

2017-10-01 18:08:01,085+0300 INFO  (jsonrpc/5) [vdsm.api] START deleteImage(sdUUID='ff9c51b2-eb5c-46c1-88ba-e4c07fb912fb', spUUID='2669a110-2c7b-45d9-86f2-4ce975a04ba2', imgUUID='b9795727-a
fcc-44cf-a189-c493fdf60305', postZero='false', force='false', discard=False) from=::ffff:10.35.161.182,58156, flow_id=493f8172-f8f1-4ec7-b3c6-45ea259e2683, task_id=11fe8358-8fba-45c9-9958-0
a321b2571f1 (api:46)


vdsm.conf:

[vars]
ssl = true

[addresses]
management_port = 54321

[irs]
discard_enable = true


vdsmd was restarted after vdsm.conf modification and before disk deletion from the block based domain.

Verified using:
vdsm-4.20.3-121.git77235c7.el7.centos.x86_64
ovirt-engine-4.2.0-0.0.master.20170929123516.git007c392.el7.centos.noarch
Comment 2 Sandro Bonazzola 2017-12-20 11:11:23 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.