Bug 1438822 – The discard_enable flag should not be used anymore in oVirt 4.2

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1438822 - The discard_enable flag should not be used anymore in oVirt 4.2

Summary:	The discard_enable flag should not be used anymore in oVirt 4.2

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	vdsm
Classification:	oVirt
Component:	General (Show other bugs)
Sub Component:
Version:	4.20.0
Hardware:	Unspecified Unspecified

Priority	unspecified Severity low (vote)
Target Milestone:	ovirt-4.2.0
Target Release:	4.20.4
Assigned To:	Idan Shaby
QA Contact:	Elad
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-04-04 09:36 EDT by Idan Shaby
Modified:	2017-12-20 06:11 EST (History)
CC List:	4 users (show)

See Also:	send_discard_when_deleting_disks configure_discard_per_domain_and_disk
Fixed In Version:
Doc Type:	Release Note
Doc Text:	With this update, support for configuring "Discard After Delete" per host has been dropped. This also drops the value "discard_enable" from the VDSM configuration file. The "Discard After Delete" feature now needs to be configured per block storage domain. For more information see - http://www.ovirt.org/develop/release-management/features/storage/discard-after-delete/
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-12-20 06:11:23 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Storage
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	rule-engine: ovirt‑4.2+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	75146	master	MERGED	storage: remove discard_enable flag from config file	2017-06-18 03:58 EDT

Groups: None (edit)

Description Idan Shaby 2017-04-04 09:36:10 EDT

Description of problem:
The discard_enable flag should not be used anymore in oVirt 4.2 as the engine manages logical volumes discarding from oVirt 4.1.

For more information, please refer to the Discard After Delete feature page:
http://www.ovirt.org/develop/release-management/features/storage/discard-after-delete/

Comment 1 Elad 2017-10-01 11:11:07 EDT

Discard is sent as false in case vdsm.conf has 'discard_enable = true' and the block based domain that its disk is deleted has discard=false.

2017-10-01 18:08:01,085+0300 INFO  (jsonrpc/5) [vdsm.api] START deleteImage(sdUUID='ff9c51b2-eb5c-46c1-88ba-e4c07fb912fb', spUUID='2669a110-2c7b-45d9-86f2-4ce975a04ba2', imgUUID='b9795727-a
fcc-44cf-a189-c493fdf60305', postZero='false', force='false', discard=False) from=::ffff:10.35.161.182,58156, flow_id=493f8172-f8f1-4ec7-b3c6-45ea259e2683, task_id=11fe8358-8fba-45c9-9958-0
a321b2571f1 (api:46)


vdsm.conf:

[vars]
ssl = true

[addresses]
management_port = 54321

[irs]
discard_enable = true


vdsmd was restarted after vdsm.conf modification and before disk deletion from the block based domain.

Verified using:
vdsm-4.20.3-121.git77235c7.el7.centos.x86_64
ovirt-engine-4.2.0-0.0.master.20170929123516.git007c392.el7.centos.noarch

Comment 2 Sandro Bonazzola 2017-12-20 06:11:23 EST

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Note You need to log in before you can comment on or make changes to this bug.