Bug 1439694

Description of problem:

katello-restore fails to restore a good full backup. After restoring pulp content, which works, it goes on to restore mongodb data and exits right away.


Version-Release number of selected component (if applicable):

Satellite 6.2.8


How reproducible:

Always, in this system at least.


Steps to Reproduce:
1. Take full backup with katello-backup
2. Run katello-restore $BKPDIR
3. Wait until pulp content is restored


Actual results:

---
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
---


Expected results:

The backup is restored and Satellite starts.


Additional info:

Looking at the katello-restore script I see the actual command used is this:

tar --selinux --overwrite --listed-incremental=/dev/null -xfz mongo_data.tar.gz -C /

The problem here is the 'z' switch. Tar can determine the format of the file to extract so it's not needed to start with. And since the file is _not_ compressed (see below) it makes it fail.

Moreover, looking at the katello-backup script I see that a filename with .gz extension is used in the tar commands for mongodb and postgresql, but the z switch is not used so a plain tar file is created. Then a gzip command is meant to compress the tar files, but they don't exist (they're tar.gz) and so they're never compressed. This step should simply be done in one go with the tar command adding -z.