Bug 1441803 (kproperty)
| Summary: | Review Request: kproperty - Property editing framework with editor widget | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-06-26 19:11:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1441798, 1441801, 1441805 | ||
|
Description
Rex Dieter
2017-04-12 18:23:08 UTC
Sample/test builds in copr (since there are several that depend on each other): https://copr.fedorainfracloud.org/coprs/rdieter/calligra3 %description should be wrapped to <80 columns.
Url, Source0: http → https.
Rpmlint
-------
Checking: kproperty-3.0.1-1.fc27.x86_64.rpm
kproperty-devel-3.0.1-1.fc27.x86_64.rpm
kproperty-debuginfo-3.0.1-1.fc27.x86_64.rpm
kproperty-3.0.1-1.fc27.src.rpm
kproperty.x86_64: E: description-line-too-long C A property editing framework with editor widget similar to what is
known from Qt Designer.
kproperty.src: E: description-line-too-long C A property editing framework with editor widget similar to what is known from Qt Designer.
Right.
kproperty.x86_64: W: no-documentation
kproperty.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kproperty.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kproperty-devel.x86_64: W: only-non-binary-in-usr-lib
kproperty-devel.x86_64: W: no-documentation
The rest is OK.
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyCore3.so.3.0 /lib64/libm.so.6
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyCore3.so.3.0 /lib64/libgcc_s.so.1
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libKF5ConfigGui.so.5
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libQt5Xml.so.5
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libm.so.6
kproperty.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKPropertyWidgets3.so.3.0 /lib64/libgcc_s.so.1
Hm, those might be worth cleaning up. At least libKF5ConfigGui, libQt5Xml.
+ package name is OK
+ licence is acceptable for Fedora (LGPLv2+)
+ license is specified correctly
+ builds and installs OK
+ P/R/BR look correct
(some Requires might be trimmed possibly)
+ scriptlets follow the guidelines
+ fedora-review finds no issues
Package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kproperty kreport-3.0.1-1.fc26 kproperty-3.0.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-800ce8f291 kproperty-3.0.1-1.fc26, kreport-3.0.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-800ce8f291 kproperty-3.0.1-1.fc26, kreport-3.0.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |