Bug 1441798 (kreport) - Review Request: kreport - Framework for creation and generation of reports
Summary: Review Request: kreport - Framework for creation and generation of reports
Keywords:
Status: CLOSED ERRATA
Alias: kreport
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: kproperty
Blocks: kde-reviews calligra3 kexi
TreeView+ depends on / blocked
 
Reported: 2017-04-12 18:18 UTC by Rex Dieter
Modified: 2017-06-26 19:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-26 19:11:43 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Rex Dieter 2017-04-12 18:18:36 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/calligra3/kreport.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/calligra3/kreport-3.0.1-1.fc25.src.rpm
Description: A framework for creation and generation of reports in multiple formats.

Fedora Account System Username: rdieter

Comment 1 Rex Dieter 2017-04-12 18:20:09 UTC
Sample/test builds in copr (since there are several that depend on each other):

https://copr.fedorainfracloud.org/coprs/rdieter/calligra3

Comment 2 Zbigniew Jędrzejewski-Szmek 2017-06-19 16:06:23 UTC
> BuildRequires: python
Shouldn't this by python2 or python3 instead? If any version is OK, maybe add a comment.

Url, Source0: http → https.

- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

I think this applies to .desktop files in /usr/share/kservicetypes5/ too. It should be validated.

rpmlint:
kreport.x86_64: W: incoherent-version-in-changelog 3.0.1-0.1 ['3.0.1-1.fc27', '3.0.1-1']
Please fix.

kreport.x86_64: W: no-documentation
kreport.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kreport.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
kreport-devel.x86_64: W: only-non-binary-in-usr-lib
kreport-devel.x86_64: W: no-documentation
All OK.

4 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ package name is OK
+ licence is acceptable for Fedora (LGPLv2+)
+ license is specified correctly
+ builds and installs OK
+ P/R/BR look correct
  (some Requires might be trimmed possibly)
+ scriptlets follow the guidelines
+ fedora-review finds no issues apart from the desktop file validation

Looks all good, apart from some minor issues which can be fixed when importing.
Package is APPROVED.

Comment 3 Gwyn Ciesla 2017-06-19 17:54:10 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kreport

Comment 4 Rex Dieter 2017-06-20 14:45:37 UTC
Re: comment #2  about .desktop files:
FYI (and IMO), desktop-validation applies only to .desktop files under /usr/share/applications, ie, those intended to appear in graphical menus.

Comment 5 Rex Dieter 2017-06-20 14:46:08 UTC
and I suppose any other xdg-mandated location for them, like /etc/xdg/autostart

Comment 6 Fedora Update System 2017-06-20 16:44:07 UTC
kreport-3.0.1-1.fc26 kproperty-3.0.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-800ce8f291

Comment 7 Fedora Update System 2017-06-21 06:24:34 UTC
kproperty-3.0.1-1.fc26, kreport-3.0.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-800ce8f291

Comment 8 Fedora Update System 2017-06-26 19:11:43 UTC
kproperty-3.0.1-1.fc26, kreport-3.0.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.