Bug 144241
Summary: | Devlabel fails to recognise SCSI drives | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 3 | Reporter: | Kevin Haines <k.b.haines> | ||||||||
Component: | devlabel | Assignee: | Karel Zak <kzak> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | |||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | 3.0 | CC: | pas37 | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | i686 | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2005-05-20 00:18:15 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 132991 | ||||||||||
Attachments: |
|
Description
Kevin Haines
2005-01-05 08:48:22 UTC
What is the difference in the output of scsi_unique_id between the two packages? I am having the same problem on the x86_64 platform. I noticed that the new version of devlabel puts a space in the id. It appears to be between the two page 83 type 3 lines from scsi_unique_id. The output of my scsi unique id is: model: IFT A16F-R1211 page80: 30303030303236383043314541333030 page83 type3: 600d023000656767000002680c1ea300 page83 type3: 200000d023600002 page83 type0: 1100000000656767000000000000000000000000 the output from devlabel printid: devlabel 0.42: S83.3:600d023000656767000002680c1ea300200000d023600002IFTA16F-R1211sector63 devlabel 0.48: S83.3:600d023000656767000002680c1ea300 200000d023600002IFTA16F-R1211sector63 I noticed in the code that the 'tr -d "\n"' has been remove after the sed statement. I think this is causing the problem. See below for the line of code from get_id() - if ID=`echo "$scsi_unique_id" | grep "page83 type3:" | sed 's/page83 type3: //' | tr -d "\n"` && [ -n "$ID" ]; then + if ID=`echo "$scsi_unique_id" | grep "page83 type3:" | sed 's/page83 type3: //'` && ID="`echo $ID`" && [ -n "$ID" ]; then I added the tr -d "\n" back in and this fixed the problem here. Bill, sorry I can't regenerate the 0.48 output because it's a production system and I needed to get it running; so I'm stuck with 0.42 for now. Phillip, thanks for the fix, I will try this during the next system downtime. Cheers Kevin Created attachment 109446 [details]
patch for this and other issues
Does this work for you?
Bill, Will try the patch during next scheduled downtime on 12th Jan. Many thanks Kevin Created attachment 109472 [details]
fix for devlabel-fixes.patch
After I fixed a missing ` in the patch, it worked for me. The new patch
corrects this.
Created attachment 109479 [details]
new patch
Actually, you want to remove the other backtick.
Thanks for spotting that, BTW. New patch works here. New patch works, many thanks. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2005-121.html |