Bug 1442550

Summary: Review Request: nodejs-option-cache - Simple API for managing options in JavaScript applications
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-18 19:06:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1442416, 1442505, 1442506, 1442514    
Bug Blocks: 956806, 1387531    

Description Jared Smith 2017-04-15 12:21:36 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-option-cache/nodejs-option-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-option-cache/nodejs-option-cache-3.4.0-2.fc27.src.rpm
Description: Simple API for managing options in JavaScript applications
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2017-09-14 16:54:48 UTC
Latest version is 4.0.0, please bump your package.

It needs arr-flatten and has-value for tests:

%if 0%{?enable_tests}
BuildRequires:	mocha
BuildRequires:	npm(arr-flatten)
BuildRequires:	npm(component-emitter)
BuildRequires:	npm(get-value)
BuildRequires:	npm(has-value)
BuildRequires:	npm(kind-of)
BuildRequires:	npm(set-value)
BuildRequires:	npm(should)
BuildRequires:	npm(to-object-path)
%endif)

arr-flatten needs to be updated to at least 1.0.3.

Comment 3 Robert-André Mauchin 🐧 2017-09-16 00:02:57 UTC
All good, package accepted.

Comment 4 Jared Smith 2017-09-16 10:59:15 UTC
'Requested package in ticket '

Comment 5 Jared Smith 2017-09-16 11:00:33 UTC
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1218'

Comment 6 Gwyn Ciesla 2017-09-18 11:17:09 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-option-cache

Comment 7 Jared Smith 2017-09-18 19:06:31 UTC
In rawhide, closing bug