Bug 1442550 - Review Request: nodejs-option-cache - Simple API for managing options in JavaScript applications
Summary: Review Request: nodejs-option-cache - Simple API for managing options in Java...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1442416 1442505 1442506 1442514
Blocks: nodejs-reviews Node-RED
TreeView+ depends on / blocked
 
Reported: 2017-04-15 12:21 UTC by Jared Smith
Modified: 2017-09-18 19:06 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-09-18 19:06:31 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2017-04-15 12:21:36 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-option-cache/nodejs-option-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-option-cache/nodejs-option-cache-3.4.0-2.fc27.src.rpm
Description: Simple API for managing options in JavaScript applications
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2017-09-14 16:54:48 UTC 
Latest version is 4.0.0, please bump your package.

It needs arr-flatten and has-value for tests:

%if 0%{?enable_tests}
BuildRequires:	mocha
BuildRequires:	npm(arr-flatten)
BuildRequires:	npm(component-emitter)
BuildRequires:	npm(get-value)
BuildRequires:	npm(has-value)
BuildRequires:	npm(kind-of)
BuildRequires:	npm(set-value)
BuildRequires:	npm(should)
BuildRequires:	npm(to-object-path)
%endif)

arr-flatten needs to be updated to at least 1.0.3.
Comment 2 Jared Smith 2017-09-15 21:58:06 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-option-cache/nodejs-option-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-option-cache/nodejs-option-cache-4.0.0-1.fc28.src.rpm
Comment 3 Robert-André Mauchin 🐧 2017-09-16 00:02:57 UTC 
All good, package accepted.
Comment 4 Jared Smith 2017-09-16 10:59:15 UTC 
'Requested package in ticket '
Comment 5 Jared Smith 2017-09-16 11:00:33 UTC 
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1218'
Comment 6 Gwyn Ciesla 2017-09-18 11:17:09 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-option-cache
Comment 7 Jared Smith 2017-09-18 19:06:31 UTC 
In rawhide, closing bug
Note You need to log in before you can comment on or make changes to this bug.