Bug 1443429

Hello,

 - Please update to latest version 4.1.10

 - Use this source so you don't have to update each time:

Source0:        http://james.ahlstrom.name/quisk/%{name}-%{version}.tar.gz

 - # make Python scripts with shebangs executable ⇒ You should instead remove the shebang from these files:

for lib in $(find %{buildroot}%{python2_sitelib}/%{name} -name '*.py'); do
 sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new &&
 touch -r $lib $lib.new &&
 mv $lib.new $lib
done

 - please only use one BR per line for clarity

 - Your patch has mostly been included upstream. The folowing:

diff -up quisk-4.1.3/quisk.py.wx-assert quisk-4.1.3/quisk.py
--- quisk-4.1.3/quisk.py.wx-assert	2016-11-30 11:26:59.000000000 -0700
+++ quisk-4.1.3/quisk.py	2017-04-19 02:50:40.476598810 -0600
@@ -1,4 +1,4 @@
-#! /usr/bin/python
+#!/usr/bin/python2

should probably be handled with sed from within the spec:

sed -i '1 s@^#! /usr/bin/python@#!/usr/bin/python2@' quisk.py

 - Source contains BSD code too:

BSD (3 clause)
--------------
quisk-4.1.10/usb/LICENSE

Spec URL: https://fedorapeople.org/~brouhaha/quisk/quisk.spec
SRPM URL: https://fedorapeople.org/~brouhaha/quisk/quisk-4.1.10-1.fc26.src.rpm

Made the requested changes except removing shebangs from scripts in libdir. While it isn't expected to be common (or they would be in bindir), executing the particular scripts that have shebangs is perfectly reasonable, and I've had one occasion to do so. As far as I'm aware, this doesn't actually violate any official guidelines.

All right, package accepted.

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/quisk

quisk-4.1.10-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8f449bf73

quisk-4.1.10-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8f449bf73

quisk-4.1.10-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5c8653be70

quisk-4.1.10-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cf4021d112

quisk-4.1.10-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

quisk-4.1.10-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

quisk-4.1.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.