Bug 1443429 - Review Request: quisk - Software Defined Radio (SDR) software
Summary: Review Request: quisk - Software Defined Radio (SDR) software
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-19 09:04 UTC by Eric Smith
Modified: 2018-03-27 19:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-01 00:04:38 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Eric Smith 2017-04-19 09:04:09 UTC
Spec URL: https://fedorapeople.org/~brouhaha/quisk/quisk.spec
SRPM URL: https://fedorapeople.org/~brouhaha/quisk/quisk-4.1.3-1.fc25.src.rpm
Description: QUISK is a Software Defined Radio (SDR) which can control various
radio hardware. QUISK supports CW, SSB, and AM.
Fedora Account System Username: brouhaha

Comment 1 Robert-André Mauchin 🐧 2017-10-01 19:43:08 UTC
Hello,

 - Please update to latest version 4.1.10

 - Use this source so you don't have to update each time:

Source0:        http://james.ahlstrom.name/quisk/%{name}-%{version}.tar.gz

 - # make Python scripts with shebangs executable ⇒ You should instead remove the shebang from these files:

for lib in $(find %{buildroot}%{python2_sitelib}/%{name} -name '*.py'); do
 sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new &&
 touch -r $lib $lib.new &&
 mv $lib.new $lib
done

 - please only use one BR per line for clarity

 - Your patch has mostly been included upstream. The folowing:

diff -up quisk-4.1.3/quisk.py.wx-assert quisk-4.1.3/quisk.py
--- quisk-4.1.3/quisk.py.wx-assert	2016-11-30 11:26:59.000000000 -0700
+++ quisk-4.1.3/quisk.py	2017-04-19 02:50:40.476598810 -0600
@@ -1,4 +1,4 @@
-#! /usr/bin/python
+#!/usr/bin/python2

should probably be handled with sed from within the spec:

sed -i '1 s@^#! /usr/bin/python@#!/usr/bin/python2@' quisk.py

 - Source contains BSD code too:

BSD (3 clause)
--------------
quisk-4.1.10/usb/LICENSE

Comment 2 Eric Smith 2017-10-10 06:36:47 UTC
Spec URL: https://fedorapeople.org/~brouhaha/quisk/quisk.spec
SRPM URL: https://fedorapeople.org/~brouhaha/quisk/quisk-4.1.10-1.fc26.src.rpm

Made the requested changes except removing shebangs from scripts in libdir. While it isn't expected to be common (or they would be in bindir), executing the particular scripts that have shebangs is perfectly reasonable, and I've had one occasion to do so. As far as I'm aware, this doesn't actually violate any official guidelines.

Comment 3 Robert-André Mauchin 🐧 2017-10-10 11:35:25 UTC
All right, package accepted.

Comment 4 Gwyn Ciesla 2017-10-10 13:26:25 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/quisk

Comment 5 Fedora Update System 2017-10-14 20:33:27 UTC
quisk-4.1.10-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8f449bf73

Comment 6 Fedora Update System 2017-10-15 03:49:12 UTC
quisk-4.1.10-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-a8f449bf73

Comment 7 Fedora Update System 2017-10-15 04:21:16 UTC
quisk-4.1.10-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5c8653be70

Comment 8 Fedora Update System 2017-10-15 05:53:35 UTC
quisk-4.1.10-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cf4021d112

Comment 9 Fedora Update System 2017-11-01 00:04:38 UTC
quisk-4.1.10-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2017-11-11 02:53:37 UTC
quisk-4.1.10-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2018-03-27 19:03:02 UTC
quisk-4.1.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.