Bug 1443689

Summary:	Check for blank password in database configuration to avoid postgres errors
Product:	Red Hat CloudForms Management Engine	Reporter:	Matouš Mojžíš <mmojzis>
Component:	Appliance	Assignee:	Yuri Rudman <yrudman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	luke couzens <lcouzens>
Severity:	medium	Docs Contact:
Priority:	high
Version:	5.8.0	CC:	abellott, jhardy, jrafanie, lcouzens, mdahlgre, obarenbo, pakotvan, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1459225 1468593 (view as bug list)		Environment:
Last Closed:	2018-03-06 15:19:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1459225, 1468593

Description Matouš Mojžíš 2017-04-19 18:13:18 UTC

Description of problem:


Version-Release number of selected component (if applicable):
5.8.0.9

How reproducible:
Always

Steps to Reproduce:
1. Launch appliance_console 
2. Go to Database configuration
3. Go through all the settings
4. In database region & password set blank password

Actual results:
Postgresql error: Validated failed with error - fe_sendauth: no password supplied
Partition was still created and prepared for postgres.

Expected results:
Blank passwords should not be allowed.

Additional info:

Comment 2 CFME Bot 2017-04-22 03:54:45 UTC

https://github.com/ManageIQ/manageiq-gems-pending/pull/125

Comment 3 CFME Bot 2017-04-25 13:18:07 UTC

New commit detected on ManageIQ/manageiq-gems-pending/master:
https://github.com/ManageIQ/manageiq-gems-pending/commit/392aa59ba04f18ee4262107a356fad564107ef83

commit 392aa59ba04f18ee4262107a356fad564107ef83
Author:     Yuri Rudman <yrudman>
AuthorDate: Fri Apr 21 16:13:48 2017 -0400
Commit:     Yuri Rudman <yrudman>
CommitDate: Mon Apr 24 16:07:42 2017 -0400

    do not allow to enter empty passwords when configuring DB
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1443689

 .../pending/appliance_console/database_configuration.rb   | 15 ++++++++++-----
 spec/appliance_console/database_configuration_spec.rb     |  9 ++++++++-
 2 files changed, 18 insertions(+), 6 deletions(-)

Comment 4 Mike Dahlgren 2017-05-20 20:29:50 UTC

I ran into this bug while testing and it leads to an appliance that is basically broken. (second partition table is created, but database is not configured)  

Can we get this backported into 5.8?

Comment 6 Yuri Rudman 2017-07-06 15:51:54 UTC

*** Bug 1467573 has been marked as a duplicate of this bug. ***

Comment 8 Matouš Mojžíš 2017-11-08 16:24:11 UTC

Verified in 5.9.0.5. It doesn't allow me to set up database without password in appliance_console.