Bug 1444110

Summary: Error flash msg of mapping tag with already existing label has additional ", " characters before label name
Product: Red Hat CloudForms Management Engine Reporter: Matouš Mojžíš <mmojzis>
Component: UI - OPSAssignee: Zohar Gal-Or <zgalor>
Status: CLOSED CURRENTRELEASE QA Contact: Matouš Mojžíš <mmojzis>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: dajohnso, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: configuration:ui:flash_msg
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1445368 (view as bug list) Environment:
Last Closed: 2018-03-06 14:40:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1445368    
Attachments:
Description Flags
additional characters in flash error message none

Description Matouš Mojžíš 2017-04-20 15:15:09 UTC
Created attachment 1273005 [details]
additional characters in flash error message

Description of problem:


Version-Release number of selected component (if applicable):
5.8.0.11

How reproducible:
Always

Steps to Reproduce:
1. Go to Configuration -> CFME Region -> Maps Tags
2. Add tag with label Test
3. Add another tag with label Test

Actual results:
There is additional ", " before Test.
Screenshot attached.

Expected results:


Additional info:

Comment 3 Zohar Gal-Or 2017-04-23 07:54:40 UTC
This is not the bug.
There should be a "," but something else is missing.
Text should be "Mapping for Instance (Amazon), Test already exists"

For some reason, the entity name: Instance (Amazon) is missing. 
Still inquiring why this happens.

Comment 4 Zohar Gal-Or 2017-04-23 13:50:11 UTC
This "missing entity" issue was caused by the same issue in https://bugzilla.redhat.com/show_bug.cgi?id=1444112

And this was fixed in PR:
https://github.com/ManageIQ/manageiq-ui-classic/pull/1122

However, I changed the text to make it clearer:
"Mapping for Instance (Amazon), Label Test already exists"

https://github.com/ManageIQ/manageiq-ui-classic/pull/1123

Comment 5 Zohar Gal-Or 2017-04-25 07:35:57 UTC
PR updated and the current error message is:

Mapping for Instance (Amazon), Label "Test" already exists

Comment 7 Matouš Mojžíš 2017-11-15 14:24:07 UTC
Verified in 5.9.0.8. Flash message is displayed correctly.