Bug 1444110 - Error flash msg of mapping tag with already existing label has additional ", " characters before label name
Summary: Error flash msg of mapping tag with already existing label has additional ", ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.9.0
Assignee: Zohar Gal-Or
QA Contact: Matouš Mojžíš
URL:
Whiteboard: configuration:ui:flash_msg
Depends On:
Blocks: 1445368
TreeView+ depends on / blocked
 
Reported: 2017-04-20 15:15 UTC by Matouš Mojžíš
Modified: 2018-08-21 10:20 UTC (History)
6 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1445368 (view as bug list)
Environment:
Last Closed: 2018-03-06 14:40:06 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
additional characters in flash error message (65.50 KB, image/png)
2017-04-20 15:15 UTC, Matouš Mojžíš 		no flags Details
View All

Description Matouš Mojžíš 2017-04-20 15:15:09 UTC 
Created attachment 1273005 [details]
additional characters in flash error message

Description of problem:


Version-Release number of selected component (if applicable):
5.8.0.11

How reproducible:
Always

Steps to Reproduce:
1. Go to Configuration -> CFME Region -> Maps Tags
2. Add tag with label Test
3. Add another tag with label Test

Actual results:
There is additional ", " before Test.
Screenshot attached.

Expected results:


Additional info:
Comment 3 Zohar Gal-Or 2017-04-23 07:54:40 UTC 
This is not the bug.
There should be a "," but something else is missing.
Text should be "Mapping for Instance (Amazon), Test already exists"

For some reason, the entity name: Instance (Amazon) is missing. 
Still inquiring why this happens.
Comment 4 Zohar Gal-Or 2017-04-23 13:50:11 UTC 
This "missing entity" issue was caused by the same issue in https://bugzilla.redhat.com/show_bug.cgi?id=1444112

And this was fixed in PR:
https://github.com/ManageIQ/manageiq-ui-classic/pull/1122

However, I changed the text to make it clearer:
"Mapping for Instance (Amazon), Label Test already exists"

https://github.com/ManageIQ/manageiq-ui-classic/pull/1123
Comment 5 Zohar Gal-Or 2017-04-25 07:35:57 UTC 
PR updated and the current error message is:

Mapping for Instance (Amazon), Label "Test" already exists
Comment 7 Matouš Mojžíš 2017-11-15 14:24:07 UTC 
Verified in 5.9.0.8. Flash message is displayed correctly.
Note You need to log in before you can comment on or make changes to this bug.