Bug 1444463

Summary: Review Request: perl-Test-Directory - Perl extension for maintaining test directories
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Test-Directory-0.041-1.fc27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-24 13:00:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1444464    

Description Petr Pisar 2017-04-21 11:35:06 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Test-Directory/perl-Test-Directory.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-Directory/perl-Test-Directory-0.041-1.fc27.src.rpm
Description:
Testing code can involve making sure that files are created and deleted as
expected. Doing this manually can be error prone, as it's easy to forget a
file, or miss that some unexpected file was added. This module simplifies
maintaining test directories by tracking their status as they are modified
or tested with this API, making it simple to test both individual files, as
well as to verify that there are no missing or unknown files.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2017-04-24 07:49:24 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-Directory-0.041-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Carp)
      1 perl(Fcntl)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(Test::Builder::Module)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Directory-0.041-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Test::Directory) = 0.041
      1 perl-Test-Directory = 0.041-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-Directory*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires are almost ok
FIX: Please add build-require 'make'

Please correct 'FIX' issue.

The package looks good.
Approved.
Comment 2 Gwyn Ciesla 2017-04-24 12:44:25 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Directory
Comment 3 Petr Pisar 2017-04-24 13:00:27 UTC 
Thank you for the review and the repository. I added the dependency on make.