Bug 1444464 - Review Request: perl-Test-WriteVariants - Dynamic generation of tests in nested combinations of contexts
Summary: Review Request: perl-Test-WriteVariants - Dynamic generation of tests in nest...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1444463
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-21 11:45 UTC by Petr Pisar
Modified: 2017-04-25 16:07 UTC (History)
2 users (show)

Fixed In Version: perl-Test-WriteVariants-0.012-1.fc27
Clone Of:
Environment:
Last Closed: 2017-04-25 16:07:00 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-04-21 11:45:45 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Test-WriteVariants/perl-Test-WriteVariants.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test-WriteVariants/perl-Test-WriteVariants-0.012-1.fc27.src.rpm
Description:
This is a library for generating Perl tests for every possible combination of
contexts. The output is another set of Perl test files.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-04-24 14:55:20 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-WriteVariants-0.012-1.fc27.noarch.rpm | sort | uniq -c
i      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(Data::Tumbler) >= 0.002
      1 perl(File::Basename)
      1 perl(File::Path)
      1 perl(Module::Pluggable::Object) >= 4.9
      1 perl(Test::WriteVariants::Context)
      1 perl(Test::WriteVariants::Context::BaseItem)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-WriteVariants-0.012-1.fc27.noarch.rpm | sort | uniq -c
      1 perl(Test::WriteVariants) = 0.012
      1 perl(Test::WriteVariants::Context)
      1 perl(Test::WriteVariants::Context::BaseItem)
      1 perl(Test::WriteVariants::Context::EnvVar)
      1 perl(Test::WriteVariants::Context::MetaInfo)
      1 perl(Test::WriteVariants::Context::ModuleUse)
      1 perl(Test::WriteVariants::Context::OurVar)
      1 perl-Test-WriteVariants = 0.012-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Test-WriteVariants*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-04-25 12:14:46 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-WriteVariants

Comment 3 Petr Pisar 2017-04-25 16:07:00 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.