Bug 1444530
Summary: | Using --efi returns a "label too long" error | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Larsen <plarsen> |
Component: | livecd-tools | Assignee: | Neal Gompa <ngompa13> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 25 | CC: | adam.stokes, bcl, bruno, dhuff, fgrose, Jasper.Hartline, katzj, ngompa13, plarsen |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | livecd-tools-24.4-1.fc26 livecd-tools-24.4-1.fc25 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-05-14 20:17:27 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Peter Larsen
2017-04-21 14:29:57 UTC
See https://github.com/livecd-tools/livecd-tools/pull/60 You might avoid this bug by using the --label option. (Aside, --msdos is redundant with --efi in livecd-iso-to-disk currently.) (In reply to Frederick Grose from comment #1) > See https://github.com/livecd-tools/livecd-tools/pull/60 > > You might avoid this bug by using the --label option. > > (Aside, --msdos is redundant with --efi in livecd-iso-to-disk currently.) There's a constraint enforced by livecd-iso-to-disk requiring the label of the EFI partition to be "EFI System Partition". Also note, that --label is used for the data partition, not the EFI partition. That's true for --msdos too. EFI can only be vfat by definition. (In reply to Peter Larsen from comment #2) > (In reply to Frederick Grose from comment #1) > > See https://github.com/livecd-tools/livecd-tools/pull/60 > > > > You might avoid this bug by using the --label option. > > > > (Aside, --msdos is redundant with --efi in livecd-iso-to-disk currently.) > > There's a constraint enforced by livecd-iso-to-disk requiring the label of > the EFI partition to be "EFI System Partition". Also note, that --label is > used for the data partition, not the EFI partition. That's true for --msdos > too. EFI can only be vfat by definition. ESP isn't technically vfat (though it is derived from it) as it has its own filesystem type defined in the UEFI spec. Do we need to set the proper fs type when we're creating the partition? Maybe it has slightly different rules... I reproduced Peter's symptoms with a device that has/had a long filesystem label with an ext4 or btrfs volume. Because commit 34c52bc68a9f7ee82293215943c565c04a483abc introduced code to preserve the original label, it neglected logic to recognize the truncation of the label by mkfs.fat to 11 bytes and to update the held variable for later comparison. The patch provided in https://github.com/livecd-tools/livecd-tools/pull/60 provides the missing logic. With this patch, the requested installation completes successfully. Peter should be able to confirm if it works. livecd-tools-24.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d5aa85fd7 livecd-tools-24.4-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7076993b7d livecd-tools-24.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d5aa85fd7 livecd-tools-24.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7076993b7d livecd-tools-24.4-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. livecd-tools-24.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. Clearing "needinfo" since the patch is out and is working. |