Description of problem: When creating livecd images using livecd-iso-to-disk, you get a fatlabel:labels can not be longer than 11 characters error. sudo livecd-iso-to-disk --noverify --format --reset-mbr --efi --overlay-size-mb 1024 --home-size-mb 2048 --unencrypted-home --msdos some.iso /dev/sdc WARNING: This will DESTROY All DATA on: /dev/sdc !! Press Enter to continue, or Ctrl C to abort. /dev/sdc: 8 bytes were erased at offset 0x00000200 (gpt): 45 46 49 20 50 41 52 54 /dev/sdc: 8 bytes were erased at offset 0x3a4fffe00 (gpt): 45 46 49 20 50 41 52 54 /dev/sdc: 2 bytes were erased at offset 0x000001fe (PMBR): 55 aa /dev/sdc: calling ioctl to re-read partition table: Success Waiting for devices to settle... mkfs.fat 4.1 (2017-01-24) mkfs.fat: warning - lowercase labels might not work properly with DOS or Windows fatlabel: labels can be no longer than 11 characters Cleaning up to exit... The label created is: sudo parted /dev/sdc print Model: UFD 3.0 Silicon-Power16G (scsi) Disk /dev/sdc: 15.7GB Sector size (logical/physical): 512B/512B Partition Table: gpt Disk Flags: Number Start End Size File system Name Flags 1 4194kB 15.7GB 15.6GB fat32 EFI System Partition boot, esp If you try to force the label to a different value, you get an error that the label MUST be "EFI System Partition". Version-Release number of selected component (if applicable): rpm -q livecd-tools livecd-tools-24.3-2.fc25.x86_64 How reproducible: Run the above command - run with --efi enabled and I've had no successful run so it's reproducing every time.
See https://github.com/livecd-tools/livecd-tools/pull/60 You might avoid this bug by using the --label option. (Aside, --msdos is redundant with --efi in livecd-iso-to-disk currently.)
(In reply to Frederick Grose from comment #1) > See https://github.com/livecd-tools/livecd-tools/pull/60 > > You might avoid this bug by using the --label option. > > (Aside, --msdos is redundant with --efi in livecd-iso-to-disk currently.) There's a constraint enforced by livecd-iso-to-disk requiring the label of the EFI partition to be "EFI System Partition". Also note, that --label is used for the data partition, not the EFI partition. That's true for --msdos too. EFI can only be vfat by definition.
(In reply to Peter Larsen from comment #2) > (In reply to Frederick Grose from comment #1) > > See https://github.com/livecd-tools/livecd-tools/pull/60 > > > > You might avoid this bug by using the --label option. > > > > (Aside, --msdos is redundant with --efi in livecd-iso-to-disk currently.) > > There's a constraint enforced by livecd-iso-to-disk requiring the label of > the EFI partition to be "EFI System Partition". Also note, that --label is > used for the data partition, not the EFI partition. That's true for --msdos > too. EFI can only be vfat by definition. ESP isn't technically vfat (though it is derived from it) as it has its own filesystem type defined in the UEFI spec. Do we need to set the proper fs type when we're creating the partition? Maybe it has slightly different rules...
I reproduced Peter's symptoms with a device that has/had a long filesystem label with an ext4 or btrfs volume. Because commit 34c52bc68a9f7ee82293215943c565c04a483abc introduced code to preserve the original label, it neglected logic to recognize the truncation of the label by mkfs.fat to 11 bytes and to update the held variable for later comparison. The patch provided in https://github.com/livecd-tools/livecd-tools/pull/60 provides the missing logic. With this patch, the requested installation completes successfully. Peter should be able to confirm if it works.
livecd-tools-24.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d5aa85fd7
livecd-tools-24.4-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7076993b7d
livecd-tools-24.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d5aa85fd7
livecd-tools-24.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7076993b7d
livecd-tools-24.4-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
livecd-tools-24.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Clearing "needinfo" since the patch is out and is working.