Bug 1444657

Summary:	Error in top level error handler hiding real error
Product:	[oVirt] vdsm	Reporter:	Nir Soffer <nsoffer>
Component:	Core	Assignee:	Nir Soffer <nsoffer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Raz Tamir <ratamir>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.20.0	CC:	bugs, tnisan
Target Milestone:	ovirt-4.2.0	Flags:	rule-engine: ovirt-4.2+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 10:52:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nir Soffer 2017-04-23 19:36:21 UTC

Description of problem:

If Task.prepare error handler fails, and dispatcher error handler fails, the real
error is hidden by an AttributeError due to wrong argument name.

Version-Release number of selected component (if applicable):
4.15.0 or later.

How reproducible:
Not reproducible without modifying the code.

Reported by pylint.

Comment 1 Nir Soffer 2017-04-24 06:06:56 UTC

Fixed upstream, this is very unlikely so I'm not sure we need this in 4.1, but
backport is trivial.

Tal, do you want to backport this?

Comment 2 Tal Nisan 2017-04-24 10:10:53 UTC

No need for a backport

Comment 3 Raz Tamir 2017-05-25 18:21:43 UTC

Verifying after reviewed the patch and according to "Not reproducible without modifying the code." in comment #0

Comment 4 Sandro Bonazzola 2017-12-20 10:52:46 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.