Bug 1444657 - Error in top level error handler hiding real error
Summary: Error in top level error handler hiding real error
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.20.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.2.0
: ---
Assignee: Nir Soffer
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-23 19:36 UTC by Nir Soffer
Modified: 2017-12-20 10:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:52:46 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 75786 0 master MERGED pylint: Fix AttributeError hiding the real error 2017-04-24 05:38:50 UTC

Description Nir Soffer 2017-04-23 19:36:21 UTC 
Description of problem:

If Task.prepare error handler fails, and dispatcher error handler fails, the real
error is hidden by an AttributeError due to wrong argument name.

Version-Release number of selected component (if applicable):
4.15.0 or later.

How reproducible:
Not reproducible without modifying the code.

Reported by pylint.
Comment 1 Nir Soffer 2017-04-24 06:06:56 UTC 
Fixed upstream, this is very unlikely so I'm not sure we need this in 4.1, but
backport is trivial.

Tal, do you want to backport this?
Comment 2 Tal Nisan 2017-04-24 10:10:53 UTC 
No need for a backport
Comment 3 Raz Tamir 2017-05-25 18:21:43 UTC 
Verifying after reviewed the patch and according to "Not reproducible without modifying the code." in comment #0
Comment 4 Sandro Bonazzola 2017-12-20 10:52:46 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.