Bug 1444761

Summary:	Size unit should be written as GiB/TiB/MiB notation.
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Keigo Noha <knoha>
Component:	glusterfs	Assignee:	Amar Tumballi <atumball>
Status:	CLOSED UPSTREAM	QA Contact:	Bala Konda Reddy M <bmekala>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rhgs-3.2	CC:	amukherj, rhs-bugs, sankarshan, vbellur
Target Milestone:	---	Keywords:	EasyFix, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1500653 (view as bug list)		Environment:
Last Closed:	2018-11-19 04:56:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Keigo Noha 2017-04-24 08:50:52 UTC

Document URL: 
Size unit should be written as GiB/TiB/MiB (binary prefix) notation.

For example, https://access.redhat.com/documentation/en-us/red_hat_gluster_storage/3.2/html/administration_guide/sect-limiting_disk_usage

~~~
gluster volume quota data limit-usage /dir 100GB
~~~

The actual implementation is GiB(binary prefix). 

c.f. https://github.com/gluster/glusterfs/blob/master/libglusterfs/src/common-utils.h

Version-Release number of selected component (if applicable):
Current

How reproducible:
Always

Actual results:
The wrong notation causes unnecessary question to support team or our customers will be confused which unit system is used.

Expected results:
The all size notation should be written as binary prefix because its current implementation.
c.f. http://physics.nist.gov/cuu/Units/binary.html

Additional info:
In current, common-utils.h or other section uses binary prefix.

Comment 4 Amar Tumballi 2017-10-11 09:45:50 UTC

REVIEW: https://review.gluster.org/18486 (logging: size unit Change to proper standard) posted (#1) for review on master by Amar Tumballi (amarts)

Comment 6 Amar Tumballi 2018-11-19 04:58:15 UTC

The next release rebase from upstream will have the fixes ported to downstream. For now not a focus in product, and we will be closing it as CLOSED-UPSTREAM for now.