Bug 1444761 - Size unit should be written as GiB/TiB/MiB notation.
Summary: Size unit should be written as GiB/TiB/MiB notation.
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: glusterfs
Version: rhgs-3.2
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Amar Tumballi
QA Contact: Bala Konda Reddy M
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-04-24 08:50 UTC by Keigo Noha
Modified: 2018-11-19 05:00 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1500653 (view as bug list)
Environment:
Last Closed: 2018-11-19 04:56:56 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github https://review.gluster.org/18486 0 None None None 2018-11-19 05:00:03 UTC

Description Keigo Noha 2017-04-24 08:50:52 UTC
Document URL: 
Size unit should be written as GiB/TiB/MiB (binary prefix) notation.

For example, https://access.redhat.com/documentation/en-us/red_hat_gluster_storage/3.2/html/administration_guide/sect-limiting_disk_usage

~~~
gluster volume quota data limit-usage /dir 100GB
~~~

The actual implementation is GiB(binary prefix). 

c.f. https://github.com/gluster/glusterfs/blob/master/libglusterfs/src/common-utils.h

Version-Release number of selected component (if applicable):
Current

How reproducible:
Always

Actual results:
The wrong notation causes unnecessary question to support team or our customers will be confused which unit system is used.

Expected results:
The all size notation should be written as binary prefix because its current implementation.
c.f. http://physics.nist.gov/cuu/Units/binary.html

Additional info:
In current, common-utils.h or other section uses binary prefix.

Comment 4 Amar Tumballi 2017-10-11 09:45:50 UTC
REVIEW: https://review.gluster.org/18486 (logging: size unit Change to proper standard) posted (#1) for review on master by Amar Tumballi (amarts)

Comment 6 Amar Tumballi 2018-11-19 04:58:15 UTC
The next release rebase from upstream will have the fixes ported to downstream. For now not a focus in product, and we will be closing it as CLOSED-UPSTREAM for now.


Note You need to log in before you can comment on or make changes to this bug.