When we implement support for root device hints in the UI, we need to start enforcing setting them for nodes that have multiple disks (see bug 1445650 for reasoning behind it). I suggest two actions:
1. Issue a validation WARNING when introspection data shows multiple disk devices, and node.properties['root_device'] is not set.
2. Issue a validation ERROR when introspection data shows that the smallest disk which is larger than 4 GiB is still smaller (or equal) than what is required by flavors.
An example. Imagine we have a baremetal flavor requiring disk of 20 GiB.
Node 1 has one disk of 40 GiB, no root device hints. No warnings of errors.
Node 2 has two disks: 40 GiB and 21 GiB, no root device hints. A warning.
Node 3 has two disks: 40 GiB and 10 GiB, no root device hints. An error, as the smallest disk will be picked for deployment.
Node 4 has two disks: 40 GiB and 10 GiB, root devices hints set. No warnings or errors.
3. Bonus point for validating that existing root devices hints point to a correct disk.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHEA-2019:2811
Comment 21Red Hat Bugzilla
2023-09-14 03:57:00 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days