Bug 1445857

Summary: Display notification message when search on Provider Topology page returns no records
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED CURRENTRELEASE QA Contact: Nandini Chandra <nachandr>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: dclarizi, hkataria, jhardy, mpovolny, obarenbo, sdoyle, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ui:topology
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1459297 (view as bug list) Environment:
Last Closed: 2018-03-06 14:47:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1459297    
Attachments:
Description Flags
Suggested resolution none

Description Nandini Chandra 2017-04-26 16:05:09 UTC
Description of problem:
-----------------------
When a search on Provider Topology page returns no records, an appropriate message such as 'No Records Found' should be displayed.


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
5.8.0.11


How reproducible:
----------------
Always


Steps to Reproduce:
-------------------
1.Navigate to the Provider Topology page.
2.Enter some string in the Search box and hit Enter.


Actual results:
---------------
If no records are returned, no message is displayed.


Expected results:
----------------
If no records are returned, an appropriate message should be displayed.


Additional info:
----------------

Comment 8 Serena 2017-05-03 03:01:24 UTC
In PatternFly, we are suggesting that when a filtered view has no results, an empty state pattern is used.  The main message should be 
"No results match the filter criteria"
There should be a blue link which says "Clear All Filters" which will clear all filters.

I'm providing an image of the empty state pattern used in a PatternFly table view so you can see the pattern.

Comment 9 Serena 2017-05-03 03:03:02 UTC
Created attachment 1275797 [details]
Suggested resolution

Comment 11 Martin Hradil 2017-05-04 15:43:53 UTC
Well, it makes very little sense to hide the whole topology when nothing is found, since the topology shows the non-relevant entries with opacity 0.2 even so.

But we can always add an overlay or something like that, if this is really necessary.

Comment 13 CFME Bot 2017-05-09 17:43:15 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/5a994811483601dec8cbb1c347789d04951f0d17

commit 5a994811483601dec8cbb1c347789d04951f0d17
Author:     Martin Hradil <mhradil>
AuthorDate: Thu May 4 16:08:42 2017 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Tue May 9 11:47:51 2017 +0000

    Topology - shared/topology/not_found - a partial to show when search matches 0 items
    
    included in all the topologies and styled so that it overlays the content
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445857

 app/assets/stylesheets/topology.css              | 10 ++++++++++
 app/views/cloud_topology/show.html.haml          |  3 +++
 app/views/container_topology/show.html.haml      |  3 +++
 app/views/infra_topology/show.html.haml          |  3 +++
 app/views/middleware_topology/show.html.haml     |  3 +++
 app/views/network_topology/show.html.haml        |  3 +++
 app/views/physical_infra_topology/show.html.haml |  3 +++
 app/views/shared/topology/_not_found.html.haml   |  5 +++++
 8 files changed, 33 insertions(+)
 create mode 100644 app/views/shared/topology/_not_found.html.haml

Comment 14 CFME Bot 2017-05-09 17:43:21 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/3ca042b180b457f5d6413cdb94cbfdca3f7bc757

commit 3ca042b180b457f5d6413cdb94cbfdca3f7bc757
Author:     Martin Hradil <mhradil>
AuthorDate: Thu May 4 16:11:17 2017 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Tue May 9 11:47:51 2017 +0000

    TopologyService - set searching & notFound on scope when appropriate
    
    so that we can show the not_found message when searching and notFound :)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1445857

 app/assets/javascripts/services/topology_service.js | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

Comment 16 Nandini Chandra 2017-11-07 04:41:04 UTC
Verified in 5.9.0.5