Description of problem: ----------------------- When a search on Provider Topology page returns no records, an appropriate message such as 'No Records Found' should be displayed. Version-Release number of selected component (if applicable): ------------------------------------------------------------- 5.8.0.11 How reproducible: ---------------- Always Steps to Reproduce: ------------------- 1.Navigate to the Provider Topology page. 2.Enter some string in the Search box and hit Enter. Actual results: --------------- If no records are returned, no message is displayed. Expected results: ---------------- If no records are returned, an appropriate message should be displayed. Additional info: ----------------
In PatternFly, we are suggesting that when a filtered view has no results, an empty state pattern is used. The main message should be "No results match the filter criteria" There should be a blue link which says "Clear All Filters" which will clear all filters. I'm providing an image of the empty state pattern used in a PatternFly table view so you can see the pattern.
Created attachment 1275797 [details] Suggested resolution
Well, it makes very little sense to hide the whole topology when nothing is found, since the topology shows the non-relevant entries with opacity 0.2 even so. But we can always add an overlay or something like that, if this is really necessary.
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/5a994811483601dec8cbb1c347789d04951f0d17 commit 5a994811483601dec8cbb1c347789d04951f0d17 Author: Martin Hradil <mhradil> AuthorDate: Thu May 4 16:08:42 2017 +0000 Commit: Martin Hradil <mhradil> CommitDate: Tue May 9 11:47:51 2017 +0000 Topology - shared/topology/not_found - a partial to show when search matches 0 items included in all the topologies and styled so that it overlays the content https://bugzilla.redhat.com/show_bug.cgi?id=1445857 app/assets/stylesheets/topology.css | 10 ++++++++++ app/views/cloud_topology/show.html.haml | 3 +++ app/views/container_topology/show.html.haml | 3 +++ app/views/infra_topology/show.html.haml | 3 +++ app/views/middleware_topology/show.html.haml | 3 +++ app/views/network_topology/show.html.haml | 3 +++ app/views/physical_infra_topology/show.html.haml | 3 +++ app/views/shared/topology/_not_found.html.haml | 5 +++++ 8 files changed, 33 insertions(+) create mode 100644 app/views/shared/topology/_not_found.html.haml
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/3ca042b180b457f5d6413cdb94cbfdca3f7bc757 commit 3ca042b180b457f5d6413cdb94cbfdca3f7bc757 Author: Martin Hradil <mhradil> AuthorDate: Thu May 4 16:11:17 2017 +0000 Commit: Martin Hradil <mhradil> CommitDate: Tue May 9 11:47:51 2017 +0000 TopologyService - set searching & notFound on scope when appropriate so that we can show the not_found message when searching and notFound :) https://bugzilla.redhat.com/show_bug.cgi?id=1445857 app/assets/javascripts/services/topology_service.js | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)
Verified in 5.9.0.5