Bug 1445921

Summary: jingle_rtp_initiate_media: 'resource' is used after being freed in an error path
Product: Red Hat Enterprise Linux 7 Reporter: Debarshi Ray <debarshir>
Component: pidginAssignee: Debarshi Ray <debarshir>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.4CC: mcepl, tpelka
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pidgin-2.10.11-3.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 20:20:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Debarshi Ray 2017-04-26 19:12:31 UTC
Coverity says:

3. pidgin-2.10.11/libpurple/protocols/jabber/jingle/rtp.c:966: freed_arg:
    "g_free" frees "resource".
5. pidgin-2.10.11/libpurple/protocols/jabber/jingle/rtp.c:969: pass_freed_arg:
    Passing freed pointer "resource" as an argument to "purple_debug_error".
#   967|   
#   968|   	if (!jbr) {
#   969|-> 		purple_debug_error("jingle-rtp", "Could not find buddy's resource - %s\n", resource);
#   970|   		return FALSE;
#   971|   	}

Patch sent upstream:
https://developer.pidgin.im/ticket/17200

Fedora bug: bug 1445915

Comment 2 Debarshi Ray 2017-04-26 19:13:34 UTC
Here is a scratch build with the proposed fix:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13093877

Comment 3 Debarshi Ray 2017-04-27 12:09:24 UTC
I have built pidgin-2.10.11-3.el7:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13096832

Comment 6 errata-xmlrpc 2017-08-01 20:20:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1854