Bug 1445921 – jingle_rtp_initiate_media: 'resource' is used after being freed in an error path

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1445921 - jingle_rtp_initiate_media: 'resource' is used after being freed in an error path

Summary:	jingle_rtp_initiate_media: 'resource' is used after being freed in an error path

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	pidgin (Show other bugs)
Sub Component:
Version:	7.4
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	rc
Target Release:	---
Assigned To:	Debarshi Ray
QA Contact:	Desktop QE
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2017-04-26 15:12 EDT by Debarshi Ray
Modified:	2017-08-01 16:20 EDT (History)
CC List:	2 users (show)

See Also:
Fixed In Version:	pidgin-2.10.11-3.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-08-01 16:20:06 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2017:1854	normal	SHIPPED_LIVE	Moderate: pidgin security, bug fix, and enhancement update	2017-08-01 14:23:14 EDT

Groups: None (edit)

Description Debarshi Ray 2017-04-26 15:12:31 EDT

Coverity says:

3. pidgin-2.10.11/libpurple/protocols/jabber/jingle/rtp.c:966: freed_arg:
    "g_free" frees "resource".
5. pidgin-2.10.11/libpurple/protocols/jabber/jingle/rtp.c:969: pass_freed_arg:
    Passing freed pointer "resource" as an argument to "purple_debug_error".
#   967|   
#   968|   	if (!jbr) {
#   969|-> 		purple_debug_error("jingle-rtp", "Could not find buddy's resource - %s\n", resource);
#   970|   		return FALSE;
#   971|   	}

Patch sent upstream:
https://developer.pidgin.im/ticket/17200

Fedora bug: bug 1445915

Comment 2 Debarshi Ray 2017-04-26 15:13:34 EDT

Here is a scratch build with the proposed fix:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13093877

Comment 3 Debarshi Ray 2017-04-27 08:09:24 EDT

I have built pidgin-2.10.11-3.el7:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13096832

Comment 6 errata-xmlrpc 2017-08-01 16:20:06 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1854

Note You need to log in before you can comment on or make changes to this bug.