Bug 1446215

Summary:	NoOpFirewallDriver is set in Nova validation on setup with composable roles
Product:	Red Hat OpenStack	Reporter:	Ola Pavlenko <opavlenk>
Component:	openstack-tripleo-validations	Assignee:	Florian Fuchs <flfuchs>
Status:	CLOSED ERRATA	QA Contact:	Udi Kalifon <ukalifon>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	11.0 (Ocata)	CC:	augol, beth.white, jjoyce, jschluet, slinaber, tvignaud
Target Milestone:	Upstream M2	Keywords:	Triaged
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-validations-8.2.1-0.20180220034948.6dc1ba3.el7ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-06-27 13:29:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ola Pavlenko 2017-04-27 13:15:39 UTC

Description of problem:
Running "NoOpFirewallDriver is set in Nova" shows success with Warning! The validation did not run on any host
Accessing compute nodes manually and checking nova.conf proves that validation should pass
The validation correctly passes on setup without composable roles

Version-Release number of selected component (if applicable):
openstack-tripleo-ui-3.1.0-9.el7ost.noarch

How reproducible:
always

Steps to Reproduce:
1. deploy overcloud with composable roles with more than 1 compute
2. run the validation 

Actual results:
shows success although didn't run on any of the hosts

Expected results:
should run, and pass

Additional info:
or fail because it didn't run

Comment 3 Florian Fuchs 2017-11-20 13:47:01 UTC

There are 2 patches which address this issue:

1. https://review.openstack.org/#/c/521534/

This changes the validation's host group to nova_compute, which means it will run on any roles that have that service installed, even if they're composable roles that are not named "Compute".

2. https://review.openstack.org/#/c/500067/

This adds a callback plugin that lets all validations fail if there are no hosts to run on.

Comment 5 Udi Kalifon 2018-05-22 09:01:21 UTC

Verified:
openstack-tripleo-validations-8.4.1-5.el7ost.noarch

Comment 7 errata-xmlrpc 2018-06-27 13:29:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:2086