Bug 1447058

Summary: Ansible Playbook service retirement option should not include hosts and extra_vars when no playbook is select
Product: Red Hat CloudForms Management Engine Reporter: Bill Wei <bilwei>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: low Docs Contact:
Priority: medium    
Version: 5.8.0CC: cpelland, dclarizi, dmisharo, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ansible:service
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1447388 (view as bug list) Environment:
Last Closed: 2018-03-06 14:32:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Ansible Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1447388    

Description Bill Wei 2017-05-01 13:58:50 UTC
This is the options field of a service template when everything is default in retirement tab

 :retirement:
    :remove_resources: yes_without_playbook
    :hosts: localhost
    :extra_vars: {}
    :fqname: "/Service/Generic/StateMachines/GenericLifecycle/Retire_Basic_Resource"

Obviously :hosts and :extra_vars should not be included. UI only needs to send 
  :remove_resources: yes_without_playbook

Comment 2 Harpreet Kataria 2017-05-01 18:26:46 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/1210

Comment 3 CFME Bot 2017-05-02 15:13:35 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/669fc5872b783e346088cf5ea464410d60c886c7

commit 669fc5872b783e346088cf5ea464410d60c886c7
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon May 1 14:25:03 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon May 1 14:25:03 2017 -0400

    send extra_vars & hosts values only when retirement playbook is selected
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447058

 .../javascripts/controllers/catalog/catalog_item_form_controller.js   | 4 ++--
 .../controllers/catalog/catalog_item_form_controller_spec.js          | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

Comment 5 Shveta 2017-10-31 18:47:11 UTC
Verification blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1506796

Comment 6 Shveta 2017-11-14 07:32:05 UTC
Fixed in 5.9.0.8.20171109215303_ed87902