Bug 1447058 - Ansible Playbook service retirement option should not include hosts and extra_vars when no playbook is select
Summary: Ansible Playbook service retirement option should not include hosts and extra...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: GA
: 5.9.0
Assignee: Harpreet Kataria
QA Contact: Shveta
URL:
Whiteboard: ansible:service
Depends On:
Blocks: 1447388
TreeView+ depends on / blocked
 
Reported: 2017-05-01 13:58 UTC by Bill Wei
Modified: 2018-03-06 14:32 UTC (History)
8 users (show)

Fixed In Version: 5.9.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1447388 (view as bug list)
Environment:
Last Closed: 2018-03-06 14:32:46 UTC
Category: ---
Cloudforms Team: Ansible
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Bill Wei 2017-05-01 13:58:50 UTC 
This is the options field of a service template when everything is default in retirement tab

 :retirement:
    :remove_resources: yes_without_playbook
    :hosts: localhost
    :extra_vars: {}
    :fqname: "/Service/Generic/StateMachines/GenericLifecycle/Retire_Basic_Resource"

Obviously :hosts and :extra_vars should not be included. UI only needs to send 
  :remove_resources: yes_without_playbook
Comment 2 Harpreet Kataria 2017-05-01 18:26:46 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/1210
Comment 3 CFME Bot 2017-05-02 15:13:35 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/669fc5872b783e346088cf5ea464410d60c886c7

commit 669fc5872b783e346088cf5ea464410d60c886c7
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon May 1 14:25:03 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon May 1 14:25:03 2017 -0400

    send extra_vars & hosts values only when retirement playbook is selected
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1447058

 .../javascripts/controllers/catalog/catalog_item_form_controller.js   | 4 ++--
 .../controllers/catalog/catalog_item_form_controller_spec.js          | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)
Comment 5 Shveta 2017-10-31 18:47:11 UTC 
Verification blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1506796
Comment 6 Shveta 2017-11-14 07:32:05 UTC 
Fixed in 5.9.0.8.20171109215303_ed87902
Note You need to log in before you can comment on or make changes to this bug.