Bug 1449328
Summary: | Review Request: zfp - Library for compressed numerical arrays with high throughput R/W random access | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | zfp-0.5.4-1.fc31 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-02-25 15:12:52 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Orion Poplawski
2017-05-09 16:04:40 UTC
Those files have very generic names: /usr/include/bitstream.h /usr/include/cache.h /usr/include/memory.h In fact, glibc has memory.h, so this package would break stuff. Dunno, ideally upstream would move all header files to /usr/include/zfp/ (except for /usr/include/zfp.h). There are tests, you could run them in %check. Looks like upstream cleaned up cache.h and memory.h, though bitstream.h remains. I've filed https://github.com/LLNL/zfp/issues/49 Spec URL: https://www.cora.nwra.com/~orion/fedora/zfp.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/zfp-0.5.4-1.el7.src.rpm * Sun Feb 24 2019 Orion Poplawski <orion> - 0.5.4-1 - Update to 0.5.4 BR: gcc and BR: gcc-c++ are missing. /usr/include/bitstream.h is a bit unfortunate, but it doesn't conflict with anything, so it's acceptable. + package name is OK + license is specified correctly (BSD) + license is acceptable for fedora + latest version + builds OK + Provides/Requires look OK + rpmlint finds no issues (just false positives about spelling and outdated demands for ldconfig) Package is APPROVED. Thanks for the review. Upstream is aware of the issue an is looking to rework the names. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/zfp |