Spec URL: https://www.cora.nwra.com/~orion/fedora/zfp.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/zfp-0.5.1-1.el7.src.rpm Description: This is zfp, an open source C/C++ library for compressed numerical arrays that support high throughput read and write random access. zfp was written by Peter Lindstrom at Lawrence Livermore National Laboratory, and is loosely based on the algorithm described in the following paper: Peter Lindstrom "Fixed-Rate Compressed Floating-Point Arrays" IEEE Transactions on Visualization and Computer Graphics, 20(12):2674-2683, December 2014 doi:10.1109/TVCG.2014.2346458 zfp was originally designed for floating-point data only, but has been extended to also support integer data, and could for instance be used to compress images and quantized volumetric data. To achieve high compression ratios, zfp uses lossy but optionally error-bounded compression. Although bit-for-bit lossless compression of floating-point data is not always possible, zfp is usually accurate to within machine epsilon in near-lossless mode. zfp works best for 2D and 3D arrays that exhibit spatial coherence, such as smooth fields from physics simulations, images, regularly sampled terrain surfaces, etc. Although zfp also provides a 1D array class that can be used for 1D signals such as audio, or even unstructured floating-point streams, the compression scheme has not been well optimized for this use case, and rate and quality may not be competitive with floating-point compressors designed specifically for 1D streams. Fedora Account System Username: orion https://koji.fedoraproject.org/koji/taskinfo?taskID=19475761
Those files have very generic names: /usr/include/bitstream.h /usr/include/cache.h /usr/include/memory.h In fact, glibc has memory.h, so this package would break stuff. Dunno, ideally upstream would move all header files to /usr/include/zfp/ (except for /usr/include/zfp.h). There are tests, you could run them in %check.
Looks like upstream cleaned up cache.h and memory.h, though bitstream.h remains. I've filed https://github.com/LLNL/zfp/issues/49 Spec URL: https://www.cora.nwra.com/~orion/fedora/zfp.spec SRPM URL: https://www.cora.nwra.com/~orion/fedora/zfp-0.5.4-1.el7.src.rpm * Sun Feb 24 2019 Orion Poplawski <orion> - 0.5.4-1 - Update to 0.5.4
BR: gcc and BR: gcc-c++ are missing. /usr/include/bitstream.h is a bit unfortunate, but it doesn't conflict with anything, so it's acceptable. + package name is OK + license is specified correctly (BSD) + license is acceptable for fedora + latest version + builds OK + Provides/Requires look OK + rpmlint finds no issues (just false positives about spelling and outdated demands for ldconfig) Package is APPROVED.
Thanks for the review. Upstream is aware of the issue an is looking to rework the names.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/zfp