Bug 1449384

Summary: storage-setup broken on docker-latest
Product: Red Hat Enterprise Linux 7 Reporter: Qian Cai <qcai>
Component: docker-latestAssignee: Lokesh Mandvekar <lsm5>
Status: CLOSED ERRATA QA Contact: atomic-bugs <atomic-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 7.4CC: amurdaca, atomic-bugs, dwalsh, lsm5, vgoyal
Target Milestone: betaKeywords: Extras
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: docker-latest-1.13.1-6.1.git3a17ad5.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1449382 Environment:
Last Closed: 2017-08-02 00:14:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Qian Cai 2017-05-09 20:42:56 UTC
Description of problem:
Since we are now shipping container-storage-setup rpm and the docker-latest daemon is now calling c-s-s to setup storage, I don't see the real need to still have /bin/docker-latest-storage-setup in the docker-latest package. It seems like just going to confuse customers and generate support calls.

Version-Release number of selected component (if applicable):
docker-latest-1.13.1-5.1.git3a17ad5.el7.x86_64
container-storage-setup-0.3.0-1.git8276a1e.el7.noarch

How reproducible:
always

Comment 1 Daniel Walsh 2017-05-09 20:45:40 UTC
Not sure what this command is going to do with container-storage-setup since it is a link it will not cause container-storage-setup to do the correct thing.

Comment 2 Daniel Walsh 2017-05-09 20:46:18 UTC
We might want to move docker-latest to using pure container-storage-setup

Comment 3 Qian Cai 2017-05-09 20:49:17 UTC
It is a symlink to container-storage-setup. The only suggest I might have is to have both docker and docker-latest daemons depends on c-s-s daemon which does not exist right now. Currently, docker depends on docker-storage-setup unit file and docker-latest depends on docker-latest-storage-setup unit file where both unit files are the same to run c-s-s.

Comment 4 Qian Cai 2017-05-09 20:54:28 UTC
Yes, don't think c-s-s is working for docker-latest right now.

Comment 5 Vivek Goyal 2017-05-09 21:05:59 UTC
I thought we had decided that -latest is not coming back. But here it is....

Anyway, I think we will need container-latest-storage-setup which works on /etc/sysconfig/docker-latest-storage-setup file and generates /etc/sysconfig/docker-latest-storage

So that probably means we will need a container-latest-storage-setup package as well to support docker-latest?

Comment 6 Daniel Walsh 2017-05-10 11:59:46 UTC
I think the best solution to this is to just ship docker-latest-storage-setup with docker-latest until we sunset it.  We should have a goal to make it go away as soon as we are comfortable with system containers and running OpenShift on system containers rather then on latest docker. then the docker version can be the latest version.   We would ship the Openshift/Kubernetes version in a system container.

Comment 7 Vivek Goyal 2017-05-10 12:37:40 UTC
I am fine with shipping -latest with old docker-latest-storage-setup stuff. That means we will have separate storage setup code in docker and docker-latest and docker-latest will actually be old code. But I can live with that, I guess. We will not be able to provide new functionality of storage setup in docker-latest. Consider it frozen.

Comment 8 Daniel Walsh 2017-05-12 12:36:03 UTC
Lokesh can you just revert the changes in docker-latest to use container-storage-setup and continue using docker-latest-storage-setup for the foreseeable future.

Comment 13 errata-xmlrpc 2017-08-02 00:14:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2345