Bug 1449921

Summary:	afr: include quorum type and count when dumping afr priv
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	replicate	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.11	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1448804	Environment:
Last Closed:	2017-05-30 18:52:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1448804
Bug Blocks:

Description Ravishankar N 2017-05-11 07:26:19 UTC

+++ This bug was initially created as a clone of Bug #1448804 +++

Dump the client quorum type ('auto' or 'fixed'). If it is 'fixed', also dump
    the quorum-count. This information will be available in the client
    statedump and in
    /<fuse_mount>/.meta/graphs/active/testvol-replicate-X/private.


This is needed to figure out the default client quorum type in a volume until https://review.gluster.org/#/c/11872/ gets reworked, as `gluster v get volname cluster.quorum-type` does not always give correct results if the default values have not been changed in a new volume.

--- Additional comment from Worker Ant on 2017-05-08 04:29:21 EDT ---

REVIEW: https://review.gluster.org/17196 (afr: include quorum type and count when dumping afr priv) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-05-08 09:10:57 EDT ---

COMMIT: https://review.gluster.org/17196 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 335555d256d444f4952ce239168f72b393370f01
Author: Ravishankar N <ravishankar>
Date:   Fri May 5 22:19:36 2017 +0530

    afr: include quorum type and count when dumping afr priv
    
    Dump the client quorum type ('auto' or 'fixed'). If it is 'fixed', also dump
    the quorum-count. This information will be available in the client
    statedump and in
    /<fuse_mount>/.meta/graphs/active/testvol-replicate-X/private.
    
    Change-Id: Idbd6e2acbd622d4e6cfabf511e649a6da0e42384
    BUG: 1448804
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/17196
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

--- Additional comment from Ravishankar N on 2017-05-09 04:36:11 EDT ---

There is a bug in the previous commit, hence sending another patch.

--- Additional comment from Worker Ant on 2017-05-09 04:37:13 EDT ---

REVIEW: https://review.gluster.org/17215 (afr: fixes to quorum-type in afr_priv_dump()) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-05-09 05:52:24 EDT ---

REVIEW: https://review.gluster.org/17215 (afr: fixes to quorum-type in afr_priv_dump()) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Worker Ant on 2017-05-10 05:45:08 EDT ---

COMMIT: https://review.gluster.org/17215 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 57bfff95c87396207e1c7de64f2db1f0730ad84d
Author: Ravishankar N <ravishankar>
Date:   Tue May 9 14:02:41 2017 +0530

    afr: fixes to quorum-type in afr_priv_dump()
    
    Include the 'none' option as well in the output. This fixes the bug in
    commit 335555d256d444f4952ce239168f72b393370f01.
    Also added a test-case.
    
    This is a
    Signed-off-by: Ravishankar N <ravishankar>
    
    Change-Id: I479a14ae69ecae5a03e85e73ed50c19b483df603
    BUG: 1448804
    Reviewed-on: https://review.gluster.org/17215
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2017-05-11 07:27:13 UTC

REVIEW: https://review.gluster.org/17243 (afr: include quorum type and count when dumping afr priv) posted (#1) for review on release-3.11 by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-05-12 13:36:43 UTC

COMMIT: https://review.gluster.org/17243 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 3769fe7bf3c2674cf3ed233e79afd039e1ce6ddc
Author: Ravishankar N <ravishankar>
Date:   Fri May 5 22:19:36 2017 +0530

    afr: include quorum type and count when dumping afr priv
    
    Squash of  https://review.gluster.org/17196 and
               https://review.gluster.org/17215
    
    Dump the client quorum type ('auto', 'fixed' or 'none'). If it is 'fixed',
    also dump the quorum-count. This information will be available in the client
    statedump and in
    /<fuse_mount>/.meta/graphs/active/testvol-replicate-X/private.
    
    Also added a test-case.
    
    Change-Id: I91367c5250b26efb35e5f7d7c397def09cc77cbc
    BUG: 1449921
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/17243
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-05-30 18:52:18 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/