Bug 1448804 - afr: include quorum type and count when dumping afr priv
Summary: afr: include quorum type and count when dumping afr priv
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1449921
TreeView+ depends on / blocked
 
Reported: 2017-05-08 08:28 UTC by Ravishankar N
Modified: 2017-09-05 17:29 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.12.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1449921 (view as bug list)
Environment:
Last Closed: 2017-08-23 07:12:00 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2017-05-08 08:28:48 UTC
Dump the client quorum type ('auto' or 'fixed'). If it is 'fixed', also dump
    the quorum-count. This information will be available in the client
    statedump and in
    /<fuse_mount>/.meta/graphs/active/testvol-replicate-X/private.


This is needed to figure out the default client quorum type in a volume until https://review.gluster.org/#/c/11872/ gets reworked, as `gluster v get volname cluster.quorum-type` does not always give correct results if the default values have not been changed in a new volume.

Comment 1 Worker Ant 2017-05-08 08:29:21 UTC
REVIEW: https://review.gluster.org/17196 (afr: include quorum type and count when dumping afr priv) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 2 Worker Ant 2017-05-08 13:10:57 UTC
COMMIT: https://review.gluster.org/17196 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 335555d256d444f4952ce239168f72b393370f01
Author: Ravishankar N <ravishankar>
Date:   Fri May 5 22:19:36 2017 +0530

    afr: include quorum type and count when dumping afr priv
    
    Dump the client quorum type ('auto' or 'fixed'). If it is 'fixed', also dump
    the quorum-count. This information will be available in the client
    statedump and in
    /<fuse_mount>/.meta/graphs/active/testvol-replicate-X/private.
    
    Change-Id: Idbd6e2acbd622d4e6cfabf511e649a6da0e42384
    BUG: 1448804
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: https://review.gluster.org/17196
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 3 Ravishankar N 2017-05-09 08:36:11 UTC
There is a bug in the previous commit, hence sending another patch.

Comment 4 Worker Ant 2017-05-09 08:37:13 UTC
REVIEW: https://review.gluster.org/17215 (afr: fixes to quorum-type in afr_priv_dump()) posted (#1) for review on master by Ravishankar N (ravishankar)

Comment 5 Worker Ant 2017-05-09 09:52:24 UTC
REVIEW: https://review.gluster.org/17215 (afr: fixes to quorum-type in afr_priv_dump()) posted (#2) for review on master by Ravishankar N (ravishankar)

Comment 6 Worker Ant 2017-05-10 09:45:08 UTC
COMMIT: https://review.gluster.org/17215 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 57bfff95c87396207e1c7de64f2db1f0730ad84d
Author: Ravishankar N <ravishankar>
Date:   Tue May 9 14:02:41 2017 +0530

    afr: fixes to quorum-type in afr_priv_dump()
    
    Include the 'none' option as well in the output. This fixes the bug in
    commit 335555d256d444f4952ce239168f72b393370f01.
    Also added a test-case.
    
    This is a
    Signed-off-by: Ravishankar N <ravishankar>
    
    Change-Id: I479a14ae69ecae5a03e85e73ed50c19b483df603
    BUG: 1448804
    Reviewed-on: https://review.gluster.org/17215
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 7 Shyamsundar 2017-09-05 17:29:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.