Bug 1451591

Summary:	cli xml status of detach tier broken
Product:	[Community] GlusterFS	Reporter:	hari gowtham <hgowtham>
Component:	tiering	Assignee:	hari gowtham <hgowtham>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.11	CC:	amukherj, bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1446362	Environment:
Last Closed:	2017-05-30 18:52:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1446362
Bug Blocks:	1451587

Description hari gowtham 2017-05-17 06:13:17 UTC

+++ This bug was initially created as a clone of Bug #1446362 +++

Description of problem:
the detach tier status in the xml format is not working properly.

Version-Release number of selected component (if applicable):
3.10 and above

How reproducible:
100%

Steps to Reproduce:
1.create a tiered volume
2.issue detach start
3.issue gluster v tier <volname> detach status --xml

Actual results:
volume detach tier status: success
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>Detach tier status successful</opErrstr>
  <volDetachTier/>
</cliOutput>

Expected results:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>Detach tier status successful</opErrstr>
  <volDetachTier>
    <nodeCount>1</nodeCount>
    <node>
      <nodeName>localhost</nodeName>
      <id>77e903ef-8400-4882-97ae-5a0e326f25b0</id>
      <files>0</files>
      <size>0</size>
      <lookups>0</lookups>
      <failures>0</failures>
      <skipped>0</skipped>
      <status>3</status>
      <statusStr>completed</statusStr>
      <runtime>0.00</runtime>
    </node>
    <aggregate>
      <files>0</files>
      <size>0</size>
      <lookups>0</lookups>
      <failures>0</failures>
      <skipped>0</skipped>
      <status>3</status>
      <statusStr>completed</statusStr>
      <runtime>0.00</runtime>
    </aggregate>
  </volDetachTier>
</cliOutput>

Additional info:

--- Additional comment from Worker Ant on 2017-04-27 14:52:25 EDT ---

REVIEW: https://review.gluster.org/17131 (TIER/CLI: detach status xml output) posted (#1) for review on master by hari gowtham (hari.gowtham005)

--- Additional comment from Worker Ant on 2017-05-02 00:55:37 EDT ---

REVIEW: https://review.gluster.org/17131 (Tier/cli: detach status xml output) posted (#2) for review on master by hari gowtham (hari.gowtham005)

--- Additional comment from Worker Ant on 2017-05-04 05:11:06 EDT ---

REVIEW: https://review.gluster.org/17131 (Tier/cli: detach status xml output) posted (#3) for review on master by hari gowtham (hari.gowtham005)

--- Additional comment from Worker Ant on 2017-05-17 01:07:43 EDT ---

COMMIT: https://review.gluster.org/17131 committed in master by Atin Mukherjee (amukherj) 
------
commit 2592fa0409d5215473b84012c69ac34d0270ef08
Author: hari gowtham <hgowtham>
Date:   Fri Apr 28 00:09:50 2017 +0530

    Tier/cli: detach status xml output
    
    Problem: detach status xml output was broken because
    of the wrong argument. The status_op sent to verify
    whether it is a tier status command was as false.
    
    Fix: the argument being passed was changed from false
    to true.
    
    Change-Id: I8cdd4dd972d6bfbb61c1182cbf4097767f83c7c5
    BUG: 1446362
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: https://review.gluster.org/17131
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: hari gowtham <hari.gowtham005>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: N Balachandran <nbalacha>

Comment 1 Worker Ant 2017-05-17 06:17:03 UTC

REVIEW: https://review.gluster.org/17315 (Tier/cli: detach status xml output) posted (#1) for review on release-3.11 by hari gowtham (hari.gowtham005)

Comment 2 Worker Ant 2017-05-17 13:51:28 UTC

COMMIT: https://review.gluster.org/17315 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit e9ae3125d09ecfc13b58bb045fabbaaee88b393c
Author: hari gowtham <hgowtham>
Date:   Fri Apr 28 00:09:50 2017 +0530

    Tier/cli: detach status xml output
    
    Problem: detach status xml output was broken because
    of the wrong argument. The status_op sent to verify
    whether it is a tier status command was as false.
    
    Fix: the argument being passed was changed from false
    to true.
    
    >Change-Id: I8cdd4dd972d6bfbb61c1182cbf4097767f83c7c5
    >BUG: 1446362
    >Signed-off-by: hari gowtham <hgowtham>
    >Reviewed-on: https://review.gluster.org/17131
    >Smoke: Gluster Build System <jenkins.org>
    >Tested-by: hari gowtham <hari.gowtham005>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Atin Mukherjee <amukherj>
    >Reviewed-by: N Balachandran <nbalacha>
    
    Change-Id: I8cdd4dd972d6bfbb61c1182cbf4097767f83c7c5
    BUG: 1451591
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: https://review.gluster.org/17315
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: hari gowtham <hari.gowtham005>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-05-30 18:52:40 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/