Bug 1446362 - cli xml status of detach tier broken
Summary: cli xml status of detach tier broken
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tiering
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: hari gowtham
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks: 1451587 1451591
TreeView+ depends on / blocked
 
Reported: 2017-04-27 18:05 UTC by hari gowtham
Modified: 2017-10-26 14:37 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.12.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1451587 1451591 (view as bug list)
Environment:
Last Closed: 2017-09-05 17:27:45 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description hari gowtham 2017-04-27 18:05:48 UTC
Description of problem:
the detach tier status in the xml format is not working properly.

Version-Release number of selected component (if applicable):
3.10 and above

How reproducible:
100%

Steps to Reproduce:
1.create a tiered volume
2.issue detach start
3.issue gluster v tier <volname> detach status --xml

Actual results:
volume detach tier status: success
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>Detach tier status successful</opErrstr>
  <volDetachTier/>
</cliOutput>

Expected results:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr>Detach tier status successful</opErrstr>
  <volDetachTier>
    <nodeCount>1</nodeCount>
    <node>
      <nodeName>localhost</nodeName>
      <id>77e903ef-8400-4882-97ae-5a0e326f25b0</id>
      <files>0</files>
      <size>0</size>
      <lookups>0</lookups>
      <failures>0</failures>
      <skipped>0</skipped>
      <status>3</status>
      <statusStr>completed</statusStr>
      <runtime>0.00</runtime>
    </node>
    <aggregate>
      <files>0</files>
      <size>0</size>
      <lookups>0</lookups>
      <failures>0</failures>
      <skipped>0</skipped>
      <status>3</status>
      <statusStr>completed</statusStr>
      <runtime>0.00</runtime>
    </aggregate>
  </volDetachTier>
</cliOutput>

Additional info:

Comment 1 Worker Ant 2017-04-27 18:52:25 UTC
REVIEW: https://review.gluster.org/17131 (TIER/CLI: detach status xml output) posted (#1) for review on master by hari gowtham (hari.gowtham005)

Comment 2 Worker Ant 2017-05-02 04:55:37 UTC
REVIEW: https://review.gluster.org/17131 (Tier/cli: detach status xml output) posted (#2) for review on master by hari gowtham (hari.gowtham005)

Comment 3 Worker Ant 2017-05-04 09:11:06 UTC
REVIEW: https://review.gluster.org/17131 (Tier/cli: detach status xml output) posted (#3) for review on master by hari gowtham (hari.gowtham005)

Comment 4 Worker Ant 2017-05-17 05:07:43 UTC
COMMIT: https://review.gluster.org/17131 committed in master by Atin Mukherjee (amukherj) 
------
commit 2592fa0409d5215473b84012c69ac34d0270ef08
Author: hari gowtham <hgowtham>
Date:   Fri Apr 28 00:09:50 2017 +0530

    Tier/cli: detach status xml output
    
    Problem: detach status xml output was broken because
    of the wrong argument. The status_op sent to verify
    whether it is a tier status command was as false.
    
    Fix: the argument being passed was changed from false
    to true.
    
    Change-Id: I8cdd4dd972d6bfbb61c1182cbf4097767f83c7c5
    BUG: 1446362
    Signed-off-by: hari gowtham <hgowtham>
    Reviewed-on: https://review.gluster.org/17131
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: hari gowtham <hari.gowtham005>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: N Balachandran <nbalacha>

Comment 5 Shyamsundar 2017-09-05 17:27:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report.

glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.