Bug 1451801

Summary: "setfacl --restore" fails due to use of uninitialized memory
Product: Red Hat Enterprise Linux 6 Reporter: Renaud Métrich <rmetrich>
Component: aclAssignee: Kamil Dudka <kdudka>
Status: CLOSED CURRENTRELEASE QA Contact: qe-baseos-daemons
Severity: high Docs Contact:
Priority: urgent    
Version: 6.9CC: fkrska, fsumsal, kdudka, ksrot, mkolaja, sct, szidek, toneata
Target Milestone: rcKeywords: EasyFix, Patch, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1451820 1464897 (view as bug list) Environment:
Last Closed: 2018-06-21 08:45:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1451820    
Bug Blocks: 1464897    
Attachments:
Description Flags
Suggested fix none

Description Renaud Métrich 2017-05-17 14:41:57 UTC 
Created attachment 1279726 [details]
Suggested fix

Description of problem:

When using "setfacl --restore <aclfile>" command, the command may fail when setting ACLs because of the reading of unitialized memory, causing unexpected code path to be executed.

Requesting backport of http://git.savannah.gnu.org/cgit/acl.git/commit?id=33f01b5d

Version-Release number of selected component (if applicable):

acl-2.2.49-7.el6.x86_64

How reproducible:

Always on customer setup, never on mine.

Additional info:

Backporting http://git.savannah.gnu.org/cgit/acl.git/commit?id=33f01b5d fixed the issue.
Comment 3 Kamil Dudka 2017-05-17 14:59:31 UTC 
As discussed privately, this is easy and safe to backport.  Moreover, the fix is already verified in customer's environment.