Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1464897 - "setfacl --restore" fails due to use of uninitialized memory
"setfacl --restore" fails due to use of uninitialized memory
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: acl (Show other bugs)
6.9
Unspecified Unspecified
urgent Severity high
: rc
: ---
Assigned To: Kamil Dudka
Martin Zelený
: EasyFix, Patch, ZStream
Depends On: 1451801
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-26 04:28 EDT by Oneata Mircea Teodor
Modified: 2017-08-22 13:28 EDT (History)
9 users (show)

See Also:
Fixed In Version: acl-2.2.49-7.el6_9.1
Doc Type: Bug Fix
Doc Text:
Cause: Heap-allocated memory was not initialized. Consequence: A spurious failure was thrown out of 'setfacl --restore' occasionally. Fix: An upstream patch has been applied on acl source code to initialize heap-allocated memory. Result: The spurious failure of 'setfacl --restore' does not occur any more.
Story Points: ---
Clone Of: 1451801
Environment:
Last Closed: 2017-08-22 13:28:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:2501 normal SHIPPED_LIVE acl bug fix update 2017-08-22 17:27:31 EDT

  None (edit)
Description Oneata Mircea Teodor 2017-06-26 04:28:12 EDT
This bug has been copied from bug #1451801 and has been proposed
to be backported to 6.9 z-stream (EUS).
Comment 5 Marc Muehlfeld 2017-07-05 07:05:20 EDT
Kamil, can you please provide me the Cause/Consequence/Fix/Result information in the Doc Text field? It helps me to prepare the problem description for the erratum. Thanks.
Comment 6 Kamil Dudka 2017-07-07 09:22:54 EDT
Done.  Sorry for the delay.
Comment 7 Martin Zelený 2017-07-17 10:08:26 EDT
Successfully verified by TJ#1957380.

Valgrind output
on old version:
==21935== Memcheck, a memory error detector
==21935== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
==21935== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
==21935== Command: setfacl --restore testFile.txt
==21935== 
==21935== Conditional jump or move depends on uninitialised value(s)
==21935==    at 0x4032FA: do_set (do_set.c:317)
==21935==    by 0x4021A1: restore (setfacl.c:187)
==21935==    by 0x4029E4: main (setfacl.c:575)
==21935== 
==21935== 
==21935== HEAP SUMMARY:
==21935==     in use at exit: 0 bytes in 0 blocks
==21935==   total heap usage: 91 allocs, 91 frees, 12,982 bytes allocated
==21935== 
==21935== All heap blocks were freed -- no leaks are possible
==21935== 
==21935== For counts of detected and suppressed errors, rerun with: -v
==21935== Use --track-origins=yes to see where uninitialised values come from
==21935== ERROR SUMMARY: 2 errors from 1 contexts (suppressed: 8 from 6)

on new version:
==24193== Memcheck, a memory error detector
==24193== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
==24193== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
==24193== Command: setfacl --restore testFile.txt
==24193== 
==24193== 
==24193== HEAP SUMMARY:
==24193==     in use at exit: 0 bytes in 0 blocks
==24193==   total heap usage: 91 allocs, 91 frees, 12,982 bytes allocated
==24193== 
==24193== All heap blocks were freed -- no leaks are possible
==24193== 
==24193== For counts of detected and suppressed errors, rerun with: -v
==24193== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 8 from 6)
Comment 9 errata-xmlrpc 2017-08-22 13:28:39 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2501

Note You need to log in before you can comment on or make changes to this bug.