Bug 1464897
| Summary: | "setfacl --restore" fails due to use of uninitialized memory | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Oneata Mircea Teodor <toneata> |
| Component: | acl | Assignee: | Kamil Dudka <kdudka> |
| Status: | CLOSED ERRATA | QA Contact: | Martin Zelený <mzeleny> |
| Severity: | high | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 6.9 | CC: | fkrska, kdudka, ksrot, mkolaja, mzeleny, rmetrich, sct, szidek, toneata |
| Target Milestone: | rc | Keywords: | EasyFix, Patch, ZStream |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | acl-2.2.49-7.el6_9.1 | Doc Type: | Bug Fix |
| Doc Text: |
Cause:
Heap-allocated memory was not initialized.
Consequence:
A spurious failure was thrown out of 'setfacl --restore' occasionally.
Fix:
An upstream patch has been applied on acl source code to initialize heap-allocated memory.
Result:
The spurious failure of 'setfacl --restore' does not occur any more.
|
Story Points: | --- |
| Clone Of: | 1451801 | Environment: | |
| Last Closed: | 2017-08-22 17:28:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1451801 | ||
| Bug Blocks: | |||
|
Description
Oneata Mircea Teodor
2017-06-26 08:28:12 UTC
Kamil, can you please provide me the Cause/Consequence/Fix/Result information in the Doc Text field? It helps me to prepare the problem description for the erratum. Thanks. Done. Sorry for the delay. Successfully verified by TJ#1957380. Valgrind output on old version: ==21935== Memcheck, a memory error detector ==21935== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al. ==21935== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info ==21935== Command: setfacl --restore testFile.txt ==21935== ==21935== Conditional jump or move depends on uninitialised value(s) ==21935== at 0x4032FA: do_set (do_set.c:317) ==21935== by 0x4021A1: restore (setfacl.c:187) ==21935== by 0x4029E4: main (setfacl.c:575) ==21935== ==21935== ==21935== HEAP SUMMARY: ==21935== in use at exit: 0 bytes in 0 blocks ==21935== total heap usage: 91 allocs, 91 frees, 12,982 bytes allocated ==21935== ==21935== All heap blocks were freed -- no leaks are possible ==21935== ==21935== For counts of detected and suppressed errors, rerun with: -v ==21935== Use --track-origins=yes to see where uninitialised values come from ==21935== ERROR SUMMARY: 2 errors from 1 contexts (suppressed: 8 from 6) on new version: ==24193== Memcheck, a memory error detector ==24193== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al. ==24193== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info ==24193== Command: setfacl --restore testFile.txt ==24193== ==24193== ==24193== HEAP SUMMARY: ==24193== in use at exit: 0 bytes in 0 blocks ==24193== total heap usage: 91 allocs, 91 frees, 12,982 bytes allocated ==24193== ==24193== All heap blocks were freed -- no leaks are possible ==24193== ==24193== For counts of detected and suppressed errors, rerun with: -v ==24193== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 8 from 6) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2501 |