Bug 1452462

Summary: [WALA] WALA deprovision process not clean up all cloudinit file
Product: Red Hat Enterprise Linux 7 Reporter: Yuhui Jiang <yujiang>
Component: WALinuxAgentAssignee: Mohammed Gamal <mmorsy>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.4CC: borisb, brendand, danis, hkrijger, jopoulso, leiwang, mmorsy, stephen.zarkos, wshi, yujiang, yuxisun
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1452464 (view as bug list) Environment:
Last Closed: 2017-07-24 09:31:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1451172    
Bug Blocks: 1452464    

Description Yuhui Jiang 2017-05-19 05:42:05 UTC
Description of problem: 
cloudinit marker file("/var/lib/cloud/sem/config_scripts_per_once.once") not remove during deprovision process
This file is a marker for cloudinit module "scripts-per-once".So if not remove this file during deprovision process,while deploy a new VM use this,during the new VM's provision process, "scripts-per-once" module check the marker file exists,so the module will skip this module's follow code,and run the next module.
So this will cause some issues in some scenarious.

Version-Release number of selected component (if applicable): 
WALinuxAgent-2.2.11-upstream 

RHEL Version: 
RHEL-7.4/RHEL-6.9

How reproducible: 
100%

Steps to Reproduce: 
1. Prepare a RHEL7.4 VM in Azure. Install cloud-init,WALA and enable them while booting
(do not modify cloudinit configuration file)
2. Check "/var/lib/cloud/sem" folder
3. Do WALA deprovision process
4. Check "/var/lib/cloud/sem" folder


Actual results: 
For step 2:
there is one file exits in folder,named "config_scripts_per_once.once"
For step 4:
the file still exists

Expected results: 
Should clean up "/var/lib/cloud/sem/" folder

Additional info:
Now,WALA only clean up below folders,
pa/deprovision/default.py(line 102-106)

Comment 2 Mohammed Gamal 2017-06-22 10:52:37 UTC
Fixed in WALA 2.2.12
See: https://github.com/Azure/WALinuxAgent/issues/721

Comment 3 Yuhui Jiang 2017-06-23 02:45:27 UTC
Verified on RHEL 7.4-20170601.0 with WALinuxAgent-2.2.12-1 that this issue has resolved.

My steps:
  refer this issue's Description

Comment 4 Yuxin Sun 2017-07-24 09:31:49 UTC
Close this issue because WALinuxAgent-2.2.14-1.el7/6 has shipped.