Bug 1453084
| Summary: | Review Request: fedora-workstation-backgrounds - Desktop backgrounds for Fedora Workstation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan Lerch <rlerch> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-31 09:23:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ryan Lerch
2017-05-22 06:06:38 UTC
I can review this naming: ok 1. sources: NOT ok $ spectool -g *.spec Getting https://releases.pagure.org/fedora-design/fedora-workstation-backgrounds-1.0.tar.gz ... curl: (22) The requested URL returned error: 404 Not Found It appears Source0 should be instead: Source0: https://releases.pagure.org/fedora-design/%{name}/%{name}-%{version}.tar.gz after fixing that, another problem, 2. unverifiable sources md5sum in src.rpm: 5312e48f37c9f7e221ee8b59f4bd5d56 fedora-workstation-backgrounds-1.0.tar.gz md5sum from downloaded source: a2b0dc0613b1090888e48eaf5c83ce5b fedora-workstation-backgrounds-1.0.tar.gz 3. licensing I'm not super familiar with CC enough to confidently determine if all the combined licenses ends up with an aggregate License: CC-BY-SA as currently specified in the .spec. I'd feel better if they were all explicitly listed to be on the safe side, so use something like: License: CC-BY-SA and CC-BY and CC0 otherwise, the form and content of the package is relatively simple and clean. Fix items 1-3, and I'll approve this. Thanks for the review! here is the new SPEC and SRPM https://ryanlerch.fedorapeople.org/fedora-workstation-backgrounds-1.1-1.fc26.src.rpm https://ryanlerch.fedorapeople.org/fedora-workstation-backgrounds.spec All three issues should be fixed in those. cheers, ryanlerch looks good now, sources: a9a55f6eaea744cbe7d1c93aa599e4f4 fedora-workstation-backgrounds-1.1.tar.gz APPROVED Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/fedora-workstation-backgrounds This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now. |