Spec URL: https://pagure.io/fedora-design/fedora-workstation-backgrounds/blob/master/f/fedora-workstation-backgrounds.spec SRPM URL: https://releases.pagure.org/fedora-design/fedora-workstation-backgrounds/fedora-workstation-backgrounds-1.0-1.fc26.src.rpm Description: The fedora-workstation-backgrounds packages contains the additional standard wallpapers for Fedora Workstation. Fedora Account System Username: ryanlerch
I can review this
naming: ok 1. sources: NOT ok $ spectool -g *.spec Getting https://releases.pagure.org/fedora-design/fedora-workstation-backgrounds-1.0.tar.gz ... curl: (22) The requested URL returned error: 404 Not Found It appears Source0 should be instead: Source0: https://releases.pagure.org/fedora-design/%{name}/%{name}-%{version}.tar.gz after fixing that, another problem, 2. unverifiable sources md5sum in src.rpm: 5312e48f37c9f7e221ee8b59f4bd5d56 fedora-workstation-backgrounds-1.0.tar.gz md5sum from downloaded source: a2b0dc0613b1090888e48eaf5c83ce5b fedora-workstation-backgrounds-1.0.tar.gz 3. licensing I'm not super familiar with CC enough to confidently determine if all the combined licenses ends up with an aggregate License: CC-BY-SA as currently specified in the .spec. I'd feel better if they were all explicitly listed to be on the safe side, so use something like: License: CC-BY-SA and CC-BY and CC0 otherwise, the form and content of the package is relatively simple and clean. Fix items 1-3, and I'll approve this.
Thanks for the review! here is the new SPEC and SRPM https://ryanlerch.fedorapeople.org/fedora-workstation-backgrounds-1.1-1.fc26.src.rpm https://ryanlerch.fedorapeople.org/fedora-workstation-backgrounds.spec All three issues should be fixed in those. cheers, ryanlerch
looks good now, sources: a9a55f6eaea744cbe7d1c93aa599e4f4 fedora-workstation-backgrounds-1.1.tar.gz APPROVED
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/fedora-workstation-backgrounds
This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now.