Bug 1456007
| Summary: | [RFE] Add support for MACsec connections to nm-connection-editor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Beniamino Galvani <bgalvani> | ||||||
| Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 7.4 | CC: | aloughla, atragler, bgalvani, fgiudici, lrintel, pgeorgie, rkhan, salmy, sukulkar, thaller, vbenes | ||||||
| Target Milestone: | rc | Keywords: | FutureFeature | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-04-10 13:24:24 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Beniamino Galvani
2017-05-26 16:34:48 UTC
Created attachment 1284746 [details]
[PATCH] editor: add macsec support
»···gtk_entry_set_text (priv->cak, cak); cak and ckn are possibly NULL, triggering an assertion. cak ?: "" Rest lgtm Created attachment 1286405 [details]
[PATCH v2] editor: add macsec support
It looks good to me as is. A minor nitpick, maybe you want to fix it :) When you add a new MACSec connection, and start editing the MACsec tab... Fill in Device and Parent (so that the "Save" tooltip no longer complains about these). Then, change Mode to EAP. Now the tooltip says: Invalid setting MACsec: macsec: EAP key management requires '802-1x' setting presence Ok, so you to to the 802-1x setting, and surprisingly the checkpox is set. That is, 802-1x is enabled, although the Save tooltip still claims it isn't. lgtm (In reply to Thomas Haller from comment #5) > When you add a new MACSec connection, and start editing the MACsec tab... > > Fill in Device and Parent (so that the "Save" tooltip no longer complains > about these). > > Then, change Mode to EAP. Now the tooltip says: > > Invalid setting MACsec: macsec: EAP key management requires '802-1x' > setting > presence > > Ok, so you to to the 802-1x setting, and surprisingly the checkpox is set. > That is, 802-1x is enabled, although the Save tooltip still claims it isn't. Fixed, thanks. Applied as: https://git.gnome.org/browse/network-manager-applet/commit/?id=c481a9366320745eb8749e4e0641f8c323788e6d Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0778 |